fix(glossary) Improve business glossary loading performance #6208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsheth2
approved these changes
Oct 14, 2022
anthonyhungnguyen
pushed a commit
to anthonyhungnguyen/zlp-datahub
that referenced
this pull request
Nov 8, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the performance of our business glossary by reducing the amount of information we're fetching from the server. We were overfetching and getting data that we didn't use that more than doubled the amount of trips to the graph index. This should significantly improve loading times for larger glossaries with lots of terms under nodes.
I also add a loading spinner on the side when data is loading and fix loading UI on a term group page to not show the "empty glossary" state when data is still loading.
Checklist