Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): add lower bound for ujson dep version #6189

Merged
merged 2 commits into from
Oct 13, 2022
Merged

fix(ingest): add lower bound for ujson dep version #6189

merged 2 commits into from
Oct 13, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 13, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 13, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 2m 33s ⏱️ + 4m 7s
   736 tests ±0     734 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 474 runs  ±0  1 470 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 4b52946. ± Comparison against base commit 6e34cd6.

@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 59s ⏱️ +11s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 4b52946. ± Comparison against base commit 6e34cd6.

@hsheth2 hsheth2 merged commit 380d0e8 into datahub-project:master Oct 13, 2022
@hsheth2 hsheth2 deleted the ujson-bound branch October 13, 2022 19:48
anthonyhungnguyen pushed a commit to anthonyhungnguyen/zlp-datahub that referenced this pull request Nov 8, 2022
@hsheth2
fix(ingest): add lower bound for ujson dep version (datahub-project#6189
31bc6e4 
)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): add lower bound for ujson dep version (datahub-project#6189
9361ff0 
)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): add lower bound for ujson dep version (datahub-project#6189
922a75f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingest S3 compressed json data without .json extension fails to generate schema
3 participants
@hsheth2 @aditya-radhakrishnan @david-leifker