Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): include raw s3 paths if s3 source #6168

Merged
merged 1 commit into from
Oct 11, 2022
Merged

feat(ingest): include raw s3 paths if s3 source #6168

merged 1 commit into from
Oct 11, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 11, 2022

Slack request: https://datahubspace.slack.com/archives/CUMUWQU66/p1665507536926039

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from treff7es October 11, 2022 19:32
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 11, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 27s ⏱️
   731 tests    729 ✔️ 2 💤 0 ❌
1 464 runs  1 460 ✔️ 4 💤 0 ❌

Results for commit 92a41a9.

@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   12m 10s ⏱️ +24s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 92a41a9. ± Comparison against base commit 21c1d37.

treff7es
treff7es approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hsheth2 hsheth2 merged commit e70c0ac into datahub-project:master Oct 11, 2022
@hsheth2 hsheth2 deleted the s3-paths branch October 11, 2022 22:55
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest): include raw s3 paths if s3 source (datahub-project#6168)
edd5b5e
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest): include raw s3 paths if s3 source (datahub-project#6168)
13d917f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es