Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add Sandbox support #6105

Merged
merged 2 commits into from
Oct 4, 2022
Merged

feat(ingest): add Sandbox support #6105

merged 2 commits into from
Oct 4, 2022

Conversation

rgudic
Copy link
Contributor

@rgudic rgudic commented Oct 3, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@rgudic rgudic marked this pull request as ready for review October 3, 2022 16:19
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 3, 2022
@shirshanka shirshanka added accepted An Issue that is confirmed as a bug by the DataHub Maintainers. community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 2s ⏱️
   719 tests    716 ✔️ 3 💤 0 ❌
1 440 runs  1 434 ✔️ 6 💤 0 ❌

Results for commit 6e02a88.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022 •
edited
Loading

Unit Test Results (build & test)

584 tests   580 ✔️  12m 55s ⏱️
143 suites      4 💤
143 files        0 ❌

Results for commit 6e02a88.

♻️ This comment has been updated with latest results.

@mayurinehate mayurinehate self-requested a review October 4, 2022 09:59
mayurinehate
mayurinehate approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shirshanka
shirshanka approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit d52fde1 into datahub-project:master Oct 4, 2022
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 21, 2022
@mayurinehate mayurinehate mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees

@mayurinehate mayurinehate

Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgudic @shirshanka @mayurinehate @maggiehays