feat(ingest): remove hardcoded env variable default for cli version #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
jjoyce0510
reviewed
Sep 28, 2022
jjoyce0510
reviewed
Sep 28, 2022
shirshanka
force-pushed
the
default-cli-version-for-ui
branch
from
6a74cc8
to
3e3f519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults are applied by gradle based on server version and burned into the application.yml resource replacing the @cliMajorVersion@ token.
One can always override this (e.g. in a fork) by setting the
UI_INGESTION_DEFAULT_CLI_VERSIONenv variable.Tested manually.
Red herring: the tsx file hardcodes the value 0.8.42 making it seem like that is the default, when it is actually not. That should be fixed in a follow-up PR.
Checklist