Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): bigquery-beta - handling complex types properly #6062

Merged
merged 4 commits into from
Sep 27, 2022

Conversation

treff7es
Copy link
Contributor

  • Handling complex types properly
  • Complex type descriptions added properly.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Complex type descriptions added properly
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 27, 2022
@treff7es
Copy link
Contributor Author

CleanShot 2022-09-27 at 15 07 00@2x

CleanShot 2022-09-27 at 15 07 54@2x

@github-actions
Copy link

github-actions bot commented Sep 27, 2022

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   12m 53s ⏱️ +6s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ±0 

Results for commit 7f334ce. ± Comparison against base commit 7da2e98.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 27, 2022

Unit Test Results (metadata ingestion)

    7 files  ±0      7 suites  ±0   1h 4m 54s ⏱️ + 1m 1s
719 tests ±0  715 ✔️ ±0  3 💤 ±0  1 ±0 
773 runs  ±0  766 ✔️ ±0  6 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit 7f334ce. ± Comparison against base commit 7da2e98.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@treff7es treff7es merged commit 3b9e979 into datahub-project:master Sep 27, 2022
@treff7es treff7es deleted the bq_complex_type branch February 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants