Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): bigquery-beta - Getting datasets with biquery client #6039

Merged
merged 2 commits into from
Sep 23, 2022
Merged

fix(ingest): bigquery-beta - Getting datasets with biquery client #6039

merged 2 commits into from
Sep 23, 2022

Conversation

treff7es
Copy link
Contributor

  • Getting datasets with biquery client instad of with SQL query because it did not work everywhere
  • Changing lists to lossylist in report
  • Fixing table name

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
Getting datasets with biquery client instead of information schema be…
f28876e 
…cause it did not worked everywhere

Changing lists to lossylist in report
Fixing table name
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 23, 2022
shirshanka
shirshanka approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@treff7es treff7es merged commit 3b1a0c5 into datahub-project:master Sep 23, 2022
@treff7es treff7es deleted the bigiqery_dataset_list_fix branch February 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @shirshanka