Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): infer aspect name from type in get_aspect #6033

Merged
merged 1 commit into from
Oct 11, 2022
Merged

feat(ingest): infer aspect name from type in get_aspect #6033

merged 1 commit into from
Oct 11, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 23, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 23, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 35s ⏱️
   717 tests    714 ✔️ 3 💤 0 ❌
1 436 runs  1 430 ✔️ 6 💤 0 ❌

Results for commit fe926e3.

@github-actions
Copy link

Unit Test Results (build & test)

564 tests  ±0   564 ✔️ ±0   13m 0s ⏱️ -19s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ❌ ±0 

Results for commit fe926e3. ± Comparison against base commit d53cbbb.

treff7es
treff7es approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsheth2 hsheth2 merged commit 95d1e01 into datahub-project:master Oct 11, 2022
@hsheth2 hsheth2 deleted the get-aspect branch October 11, 2022 20:35
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest): infer aspect name from type in get_aspect (datahub-proj…
901386c 
…ect#6033)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest): infer aspect name from type in get_aspect (datahub-proj…
fec5676 
…ect#6033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es