Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve doc generation, add better docs for snowflake, looker #5867

Merged
merged 1 commit into from
Sep 8, 2022
Merged

docs: improve doc generation, add better docs for snowflake, looker #5867

merged 1 commit into from
Sep 8, 2022

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   55m 53s ⏱️ -46s
   683 tests ±0     680 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 366 runs  ±0  1 360 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit c9a523d. ± Comparison against base commit 6f09f10.

treff7es
treff7es approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shirshanka shirshanka merged commit d911b15 into datahub-project:master Sep 8, 2022
hsheth2 pushed a commit to hsheth2/datahub that referenced this pull request Sep 8, 2022
@shirshanka @hsheth2
docs(ingest): improve doc gen, docs for snowflake, looker (datahub-pr…
569e058 
…oject#5867)
shirshanka added a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@shirshanka
docs(ingest): improve doc gen, docs for snowflake, looker (datahub-pr…
fe73ab9 
…oject#5867)
shirshanka added a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@shirshanka
docs(ingest): improve doc gen, docs for snowflake, looker (datahub-pr…
5cc3310 
…oject#5867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @treff7es