Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ingest): add ALL_ENV_TYPES constant #5866

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 8, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   59m 44s ⏱️ + 3m 5s
   683 tests ±0     680 ✔️ ±0  3 💤 ±0  0 ±0 
1 366 runs  ±0  1 360 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 851ef5e. ± Comparison against base commit 6f09f10.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unit Test Results (build & test)

521 tests  ±0   521 ✔️ ±0   14m 13s ⏱️ -35s
122 suites ±0       0 💤 ±0 
122 files   ±0       0 ±0 

Results for commit 851ef5e. ± Comparison against base commit 6f09f10.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 merged commit da46dcd into datahub-project:master Sep 8, 2022
@hsheth2 hsheth2 deleted the refactor-valid-fabrics branch September 8, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants