Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): Update Dockerfiles to use java 11 runtime #5853

Merged
merged 4 commits into from
Sep 8, 2022
Merged

feat(docker): Update Dockerfiles to use java 11 runtime #5853

merged 4 commits into from
Sep 8, 2022

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Sep 7, 2022 •
edited
Loading

Updates docker files to use openjdk 11 rather than openjdk8, this is in preparation to make DataHub's java docker containers make use of container native features like https://www.eclipse.org/openj9/docs/xxusecontainersupport/.

This opens up the possibility to control java heap based on container sizes making DataHub work better in a cloud-native scenario.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@pedro93 pedro93 added the devops PR or Issue related to DataHub backend & deployment label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022 •
edited
Loading

Unit Test Results (build & test)

521 tests  ±0   521 ✔️ ±0   14m 42s ⏱️ +28s
122 suites ±0       0 💤 ±0 
122 files   ±0       0 ❌ ±0 

Results for commit 8acaaa0. ± Comparison against base commit b9068ff.

♻️ This comment has been updated with latest results.

anshbansal
anshbansal approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes

@anshbansal anshbansal merged commit 7d0f543 into datahub-project:master Sep 8, 2022
@anshbansal anshbansal deleted the bump-jre-to-java-11 branch September 8, 2022 12:09
hsheth2 pushed a commit to hsheth2/datahub that referenced this pull request Sep 8, 2022
@pedro93 @hsheth2
feat(docker): Update Dockerfiles to use java 11 runtime (datahub-proj…
a5eadc1 
…ect#5853)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@pedro93 @shirshanka
feat(docker): Update Dockerfiles to use java 11 runtime (datahub-proj…
0626b97 
…ect#5853)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@pedro93 @shirshanka
feat(docker): Update Dockerfiles to use java 11 runtime (datahub-proj…
af7c3b6 
…ect#5853)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

@shirshanka shirshanka Awaiting requested review from shirshanka

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro93 @anshbansal