-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest): improve tableau lineage, workbooks query, fix pagination #5756
feat(ingest): improve tableau lineage, workbooks query, fix pagination #5756
Conversation
ae8f8e9
to
8773816
Compare
Does this PR also address this concern? |
Not all of the concerns. Only part where page_size needs to be supported for customSQLTablesConnection and publishedDatasourcesConnection queries. |
9b10af8
to
cc2f4f8
Compare
@mayurinehate I don't know if we should make this PR bigger. But i observed some behaviour with Tableau Metadata API with regarding CustomSQLTables (we have some very complex custom sql in tableau, that's how i noticed the behaviour):
I will put some sample payload up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merging this to make progress and improve this connector.
We can improve on the cases @cuong-pham mentioned in a future PR.
Changes:
platform_instance_map
config to specify platform instance for external tables (e.g. snowflake, hive)lineage_overrides.platform_override_map
embeddedDatasourcesConnection
fromworkbooksConnection
query to avoid node limit exceeded error for complex workbooks [Issue]Checklist