Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion): Update developer docs #5644

Merged
merged 2 commits into from
Aug 15, 2022
Merged

fix(ingestion): Update developer docs #5644

merged 2 commits into from
Aug 15, 2022

Conversation

szalai1
Copy link
Contributor

@szalai1 szalai1 commented Aug 15, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

treff7es
treff7es approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 19m 10s ⏱️
   643 tests    641 ✔️ 2 💤 0 ❌
1 286 runs  1 281 ✔️ 5 💤 0 ❌

Results for commit 35cd312.

@shirshanka shirshanka merged commit b496994 into datahub-project:master Aug 15, 2022
@szalai1 szalai1 deleted the update-ingestion-docs branch August 16, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szalai1 @treff7es @shirshanka