Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql): handle null source values in ml features & primary keys #5626

Merged
merged 1 commit into from
Aug 11, 2022
Merged

fix(graphql): handle null source values in ml features & primary keys #5626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,16 +1247,26 @@ private void configureMLFeatureTableResolvers(final RuntimeWiring.Builder builde
)
.type("MLFeatureProperties", typeWiring -> typeWiring
.dataFetcher("sources", new LoadableTypeBatchResolver<>(datasetType,
(env) -> ((MLFeatureProperties) env.getSource()).getSources().stream()
.map(datasetType.getKeyProvider())
.collect(Collectors.toList()))
(env) -> {
if (((MLFeatureProperties) env.getSource()).getSources() == null) {
return Collections.emptyList();
}
return ((MLFeatureProperties) env.getSource()).getSources().stream()
.map(datasetType.getKeyProvider())
.collect(Collectors.toList());
})
)
)
.type("MLPrimaryKeyProperties", typeWiring -> typeWiring
.dataFetcher("sources", new LoadableTypeBatchResolver<>(datasetType,
(env) -> ((MLPrimaryKeyProperties) env.getSource()).getSources().stream()
(env) -> {
if (((MLPrimaryKeyProperties) env.getSource()).getSources() == null) {
return Collections.emptyList();
}
return ((MLPrimaryKeyProperties) env.getSource()).getSources().stream()
.map(datasetType.getKeyProvider())
.collect(Collectors.toList()))
.collect(Collectors.toList());
})
)
)
.type("MLModel", typeWiring -> typeWiring
Expand Down