Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): fix delta-lake dict iteration bug #5625

Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 11, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 15m 56s ⏱️
   643 tests    641 ✔️ 2 💤 0
1 286 runs  1 281 ✔️ 5 💤 0

Results for commit 583d0e1.

@github-actions
Copy link

Unit Test Results (build & test)

499 tests  ±0   499 ✔️ ±0   9m 20s ⏱️ +38s
115 suites ±0       0 💤 ±0 
115 files   ±0       0 ±0 

Results for commit 583d0e1. ± Comparison against base commit e9494f5.

@maggiehays maggiehays added the ingestion PR or Issue related to the ingestion of metadata label Aug 12, 2022
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit a991dc9 into datahub-project:master Aug 12, 2022
@hsheth2 hsheth2 deleted the delta-lake-value-unpack-bug branch December 15, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants