-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui) Followups to recent changes to UI ingestion forms #5602
fix(ui) Followups to recent changes to UI ingestion forms #5602
Conversation
setValueOnRecipeOverride: (recipe: any, values: string[]) => | ||
setDottedFieldValuesOnRecipe(recipe, values, saslUsernameFieldPath), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to be able to simplify this!
@@ -74,7 +75,18 @@ import { | |||
TOPIC_DENY, | |||
} from './kafka'; | |||
|
|||
export const RECIPE_FIELDS = { | |||
interface RecipeFields { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, why did you opt for interface
here? I usually use type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so as far as I understand, the two are very often interchangeable. I usually default to interface
because interface
names show up in error messages which helps for debugging and have some extra functionality like extending (not that I'm using that here). I have always used type
for basically giving a name to a primitive type for readability.
I don't think either are wrong and neither is the obvious right choice either!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the dotted fields only able to be provided that way? so if you put
sasl:
username: true
that would be considered invalid in the kafka recipe?
@gabe-lyons I'm actually not positive. I'd like to think this would still be considered valid, but I never dug too deep into it. I just know in our docs and example recipe we have the dotted key like |
We recently merged in a big change to ingestion forms in the UI and this PR addresses some followups after that.
removeMargin
optional prop for styling to SecretFieldRECIPE_FIELDS
objectfieldPath
s that are both strings and a list of strings (for field keys that are dotted ie.sasl.username
)Checklist