Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add snowflake-beta source #5517

Merged
merged 5 commits into from
Aug 16, 2022
Merged

feat(ingest): add snowflake-beta source #5517

merged 5 commits into from
Aug 16, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jul 28, 2022 •
edited
Loading

Unit Test Results (build & test)

502 tests  ±0   502 ✔️ ±0   8m 17s ⏱️ -2s
116 suites ±0       0 💤 ±0 
116 files   ±0       0 ❌ ±0 

Results for commit 23e0006. ± Comparison against base commit a991dc9.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal added the ingestion PR or Issue related to the ingestion of metadata label Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Jul 28, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 16m 3s ⏱️ - 2m 42s
   643 tests ±0     641 ✔️ +1  2 💤 ±0  0 ❌  - 1 
1 286 runs  ±0  1 282 ✔️ +1  4 💤 ±0  0 ❌  - 1 

Results for commit 23e0006. ± Comparison against base commit a991dc9.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit dc08bed into datahub-project:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayurinehate @shirshanka @anshbansal