Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): add new ingestion source PowerBI Report Server #5369

Conversation

alcoccoque
Copy link
Contributor

@alcoccoque alcoccoque commented Jul 11, 2022

This PR adds a new ingestion source PowerBI Report Server.

Metadata that can be ingested:

  • report name
  • report description
  • data sources
  • ownership(add an existing user with graphql queries or creates new)
  • transfer folders structure to DataHub as it is in Report Server
  • webUrl to report in Report Server

Due to the limits of PBIRS REST API, it's impossible to ingest following data for now:

  • tiles info
  • full datasource of report
  • dataset of the report

Next types of reports can be ingested:

  • PowerBI report(.pbix)
  • Paginated report(.rdl)
  • Mobile report
  • Linked report

Mapping:
Report -> Dashboard

Why PowerBI Report Server is a new ingest module?

  • PowerBI Report Server has its API to retrieve metadata( PowerBI Cloud uses another API)
  • PowerBI Report Server has different authentication compared to PowerBI Cloud
  • PowerBI Report Server and PowerBI Cloud are just different sources, Report Server can sync reports with Cloud but it works only manually and for specific reports, so you can't substitute Report Server with Cloud

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@shirshanka shirshanka added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Jul 11, 2022

Unit Test Results (build & test)

599 tests  ±0   595 ✔️ ±0   12m 1s ⏱️ -2s
149 suites ±0       4 💤 ±0 
149 files   ±0       0 ±0 

Results for commit e91a058. ± Comparison against base commit 0dc2d6a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 11, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 36s ⏱️ +58s
   757 tests +1     754 ✔️ +3  3 💤 ±0  0  - 2 
1 516 runs  +2  1 510 ✔️ +4  6 💤 ±0  0  - 2 

Results for commit e91a058. ± Comparison against base commit 0dc2d6a.

♻️ This comment has been updated with latest results.

oleks.lytvynov and others added 24 commits September 2, 2022 11:59
…report_server' into feature/lytvynov_chyhir_powerbi_report_server
…report_server' into feature/lytvynov_chyhir_powerbi_report_server
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 0a0cf70 into datahub-project:master Nov 1, 2022
anthonyhungnguyen pushed a commit to anthonyhungnguyen/zlp-datahub that referenced this pull request Nov 8, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@siddiquebagwan
Copy link
Contributor

Hi @alcoccoque
Could you please look at the issue reported on the datahub slack https://datahubspace.slack.com/archives/CUMUWQU66/p1676377452280029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants