Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): add missing dependency on aws common #5273

Closed

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Jun 28, 2022

#5259 made changes which added dependencies but those are missing from setup.py

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 11m 56s ⏱️
   586 tests    583 ✔️   3 💤 0
1 110 runs  1 067 ✔️ 43 💤 0

Results for commit 3fbbfc3.

@github-actions
Copy link

Unit Test Results (build & test)

390 tests  ±0   390 ✔️ ±0   10m 59s ⏱️ -13s
  92 suites ±0       0 💤 ±0 
  92 files   ±0       0 ±0 

Results for commit 3fbbfc3. ± Comparison against base commit 99890cd.

@anshbansal anshbansal closed this Jun 28, 2022
@anshbansal anshbansal deleted the fix-dependencies branch June 28, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants