Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): Change favicon and logo to be datahub instead of linkedin #1938

Merged
merged 1 commit into from
Oct 15, 2020
Merged

feat(frontend): Change favicon and logo to be datahub instead of linkedin #1938

merged 1 commit into from
Oct 15, 2020

Conversation

cptran777
Copy link
Contributor

Summary

  • Custom favicon and title? #1855 Addresses issue raised where we were using the LinkedIn logo for datahub instead of a general one for open source. This open sources the datahub logo as both the app logo and the favicon.
  • Also includes instructions on how to change the logo in the documentation folder for datahub-web

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@cptran777 cptran777 added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 14, 2020
@cptran777 cptran777 merged commit d24c396 into master Oct 15, 2020
@cptran777 cptran777 deleted the fe-app-logo-change branch October 15, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igbopie igbopie Awaiting requested review from igbopie

@nagarjunakanamarlapudi nagarjunakanamarlapudi Awaiting requested review from nagarjunakanamarlapudi

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cptran777