Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Catchup frontend for internal development changes #1933

Merged
merged 2 commits into from
Oct 11, 2020

Conversation

cptran777
Copy link
Contributor

@cptran777 cptran777 commented Oct 10, 2020

This PR catches up various internal changes in order for us to make a PR more dedicated to addressing specific raised issues. It is also an experiment with a new script for streamlining translating internal changes to open source.

Changes include:

  • Migration of some modules out of the data-portal host application into its own addons, making it more scalable in the future
  • Removal of some internal logics that was leaked into open source
  • Updates to change management feature, which allows for email drafting and notification to specific people and groups
  • Various minor code clean ups and improvements

Testing done:

Ran docker images and ensured that application still builds and behaves as expected.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@cptran777 cptran777 added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 10, 2020
@cptran777 cptran777 merged commit 10aab5c into master Oct 11, 2020
@cptran777 cptran777 deleted the fe-catchup-10-9-2020 branch October 11, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant