Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): handle mssql casing issues in lineage #11920

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 21, 2024

MSSQL is case insensitive but case preserving. To handle this, we treat
identifiers as case insensitive.

Requires that convert_urns_to_lowercase: true is set during ingestion.
Closes #11322.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

MSSQL is case insensitive but case preserving. To handle this, we treat
identifiers as case insensitive.

Requires that `convert_urns_to_lowercase: true` is set during ingestion.
Closes #11322.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 21, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 21, 2024
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 21, 2024
@hsheth2 hsheth2 added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed pending-submitter-merge labels Nov 22, 2024
@hsheth2 hsheth2 merged commit 1bfd4ee into master Nov 22, 2024
90 of 100 checks passed
@hsheth2 hsheth2 deleted the mssql-cll-casing branch November 22, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL Column Level Lineage Case Sensitivity
2 participants