Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): incorrect month showing in MAU #11918

Merged

Conversation

kevinkarchacryl
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 21, 2024
@kevinkarchacryl
Copy link
Contributor Author

In the analytics MAU chart, the months were displaying as the last day instead of the first day of the next month, confusing users. After this fix, Sep 30 should show up as Oct 1 etc.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 21, 2024
@anshbansal anshbansal requested review from jjoyce0510 and removed request for skrydal, anshbansal and eboneil November 22, 2024 10:14
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Have you been able to validate this localy? If you can provide any before and after screenshots that wouldb be useful!

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Nov 22, 2024
@kevinkarchacryl
Copy link
Contributor Author

Thanks for the PR. Have you been able to validate this localy? If you can provide any before and after screenshots that wouldb be useful!

Here's a screenshot of before. The last tick shows "Sept 30" but is actually for the month of October. The months at the bottom actually show the last day from the previous month if you hover over them.
image

Here's a screenshot of after. Hovering over the last tick correctly shows "Oct 1". Months on the X-axis are also right.
image

@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Nov 22, 2024
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. Thank you for sharing! I've started full CI. Let's get this in!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 22, 2024
@kevinkarchacryl kevinkarchacryl merged commit e7e208f into datahub-project:master Nov 22, 2024
118 of 154 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants