Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display username while removing the user from the group #11438

Closed
wants to merge 29 commits into from

Conversation

kanavnarula
Copy link
Contributor

@kanavnarula kanavnarula commented Sep 20, 2024

This change is to display username (for the confirmation) while removing the user from the group.

Before:
image

After:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Sep 20, 2024
Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kanavnarula
Copy link
Contributor Author

kanavnarula commented Sep 20, 2024

@david-leifker - Does it make sense to keep double quotes around the username in remove group modal capture above. Please suggest.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kanavnarula!

Thanks for the contribution. In general, the idea makes sense . The following comment must be addressed before merging this one in:

  • We never should use the "URN" of the user to display their name, as we are doing in this PR. Instead, we should use the display name of the entity which can be obtained via entityRegistry.getDisplayName(EntityType.CorpUser, entity)

Thanks
John

@kanavnarula
Copy link
Contributor Author

Hi @kanavnarula!

Thanks for the contribution. In general, the idea makes sense . The following comment must be addressed before merging this one in:

  • We never should use the "URN" of the user to display their name, as we are doing in this PR. Instead, we should use the display name of the entity which can be obtained via entityRegistry.getDisplayName(EntityType.CorpUser, entity)

Thanks John

Hi @jjoyce0510,

Thanks for looking in the PR. URN was coming as string to the function so could not use entityRegistry.getDisplayName(EntityType.CorpUser, entity).

I have updated the function signature to accept CorpUser entity instead of string. Please check and suggest if these changes are looking fine.

Thanks
Kanav Narula

@rtekal
Copy link
Contributor

rtekal commented Sep 30, 2024

@jjoyce0510 When you get a chance, please review this PR. Thanks in advance.

@kanavnarula
Copy link
Contributor Author

@jjoyce0510 - Did you get chance to check the PR changes.

@kanavnarula
Copy link
Contributor Author

@jjoyce0510 @david-leifker - Please review when you get chance. Thanks in advance!

Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it addressed the comments. Going to merge. Thanks!

@@ -137,12 +137,13 @@ export default function GroupMembers({ urn, pageSize, isExternalGroup, onChangeM
}, 3000);
};

const onRemoveMember = (memberUrn: string) => {
const onRemoveMember = (memberEntity: CorpUser) => {
const memberName = memberEntity?.properties?.displayName || undefined;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use entityRegistry.getDisplayName(EntityType.CorpUser, memberEntity)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjoyce0510 - Logic updated to pull display name using above command. Thanks!

@david-leifker david-leifker self-requested a review October 22, 2024 16:49
@kanavnarula
Copy link
Contributor Author

@jjoyce0510 @david-leifker - Closing this PR as I messed up by adding other file changes related to another contribution.
New PR created - #11706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants