-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom highlight on search #11339
Feature/custom highlight on search #11339
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like a linting failure. This can be fixed up by running and commiting the changes from |
thank you @david-leifker . have updated with lint commit . Could you please reapprove . |
Looks like some missing files due to the schema change.
|
@david-leifker can you please rerun the failed step , looks like some timeout happened |
@coderabbitai summary |
This PR aims to introduce a new feature to enable custom highlighting while searching via Datahub native graphql queries .
By default , Datahub graphql engine adds all searchable fields inside elastic search highlighter which adds huge overhead if the search universe is large and have enriched description on column level . Because for each field mentioned in the highlighter , Elastic search reruns another in memory indexing per entity .
We have introduced a new field called customHighlightingFields where user can pass the fields which they want to highlight , we then only take these fields in to account for search highlighting . This features enables faster retrieval of data and offers customization .
Please refer below on the usage -
**Highlight with Valid Field **
Custom Highlight when highlighting disabled
Custom Highlight with empty fields array ( It default backs to original highlighting in case of empty array or invalid items)