-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphql): Lazy dataLoaders #11293
feat(graphql): Lazy dataLoaders #11293
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
53c9ab4
to
94b1c90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge after green CI
94b1c90
to
e1cf3af
Compare
e1cf3af
to
0065d4b
Compare
@@ -72,6 +72,8 @@ datahub: | |||
host: ${DATAHUB_GMS_HOST:localhost} | |||
port: ${DATAHUB_GMS_PORT:8080} | |||
useSSL: ${DATAHUB_GMS_USE_SSL:${GMS_USE_SSL:false}} | |||
async: | |||
request-timeout-ms: ${DATAHUB_GMS_ASYNC_REQUEST_TIMEOUT_MS:55000} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to dataLoaders, however this configuration does allow more then the default 30s for resolving + loading data.
When using test/quickstart data locally a reduction in latency is significant however it will not impact all queries and may not be significant in other environments.
Before:
After:
Checklist