-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion/bigquery): Add ability to filter GCP project ingestion based on project labels #11169
feat(ingestion/bigquery): Add ability to filter GCP project ingestion based on project labels #11169
Conversation
…gquery_config.py Co-authored-by: Tamas Nemeth <[email protected]>
…:anaghshineh/datahub into bq-filter-ingestion-based-on-proj-labels
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
…thub.com:sid-acryl/datahub-fork into ing-690-bq-filter-ingestion-based-on-proj-labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, pending testing
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_config.py
Outdated
Show resolved
Hide resolved
…thub.com:sid-acryl/datahub-fork into ing-690-bq-filter-ingestion-based-on-proj-labels
Testing is done and it is working fine with |
…thub.com:sid-acryl/datahub-fork into ing-690-bq-filter-ingestion-based-on-proj-labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a lint failure
No description provided.