Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/snowflake): allow iceberg tables in lineage and access metadata #10961

Merged
merged 6 commits into from
Aug 22, 2024
Merged

feat(ingest/snowflake): allow iceberg tables in lineage and access metadata #10961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff56951
feat(snowflake): allow iceberg tables in lineage and access metadata
alisa-aylward-toast Jul 22, 2024
300df65
feat: add iceberg table to test
alisa-aylward-toast Jul 22, 2024
5ae1378
Merge branch 'master' into feat-add-iceberg-lineage-support-in-snowflake
alisa-aylward-toast Jul 23, 2024
fcdcdd2
Merge branch 'master' into feat-add-iceberg-lineage-support-in-snowflake
alisa-aylward-toast Aug 6, 2024
b7540e6
Merge branch 'master' into feat-add-iceberg-lineage-support-in-snowflake
alisa-aylward-toast Aug 20, 2024
ab20013
Merge branch 'master' into feat-add-iceberg-lineage-support-in-snowflake
alisa-aylward-toast Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions metadata-ingestion/src/datahub/ingestion/source/snowflake/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class SnowflakeObjectDomain(str, Enum):
DATABASE = "database"
SCHEMA = "schema"
COLUMN = "column"
ICEBERG_TABLE = "iceberg table"


GENERIC_PERMISSION_ERROR_KEY = "permission-error"
Expand Down
1 change: 1 addition & 0 deletions metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class SnowflakeQuery:
SnowflakeObjectDomain.EXTERNAL_TABLE.capitalize(),
SnowflakeObjectDomain.VIEW.capitalize(),
SnowflakeObjectDomain.MATERIALIZED_VIEW.capitalize(),
SnowflakeObjectDomain.ICEBERG_TABLE.capitalize(),
}

ACCESS_HISTORY_TABLE_VIEW_DOMAINS_FILTER = "({})".format(
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/tests/integration/snowflake/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
on basic_usage_counts.bucket_start_time = user_usage_counts.bucket_start_time
and basic_usage_counts.object_name = user_usage_counts.object_name
where
basic_usage_counts.object_domain in ('Table','External table','View','Materialized view')
basic_usage_counts.object_domain in ('Table','External table','View','Materialized view','Iceberg table')
and basic_usage_counts.object_name is not null
group by
basic_usage_counts.object_name,
Expand Down
Loading