feat(custom-plugins): improve plugin factory merge #10796
Conversation
github-actions
bot
added
the
devops
entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/PluginFactory.java
Show resolved
Hide resolved
entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/PluginFactory.java
Show resolved
Hide resolved
david-leifker
force-pushed
the
plugin-factory-merge
branch
from
8ab53af
to
62fb66e
Compare
WalkthroughThe update enhances plugin management in the metadata service, with the primary changes including improved merging logic for Changes
Sequence Diagram(s)sequenceDiagram
actor Developer as Developer
participant PluginFactory
participant PluginConfiguration
participant SpringPluginFactory
participant Test
Developer->>PluginFactory: Construct PluginFactory with plugins
PluginFactory->>PluginConfiguration: Check isEmpty()
PluginConfiguration-->>PluginFactory: Response
Developer->>PluginFactory: Merge Plugins
PluginFactory->>PluginFactory: Merge Logic
Developer->>SpringPluginFactory: Load Plugins with Spring Context
SpringPluginFactory->>SpringContext: Fetch Plugin Beans
SpringContext-->>SpringPluginFactory: Return Beans
Developer->>Test: Execute Tests
Test->>PluginFactory: Validate Merged Plugins
Test->>SpringPluginFactory: Validate Loaded Plugins
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/PluginFactory.java (3 hunks)
- entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/config/PluginConfiguration.java (1 hunks)
- entity-registry/src/test/java/com/linkedin/metadata/aspect/plugins/PluginsTest.java (1 hunks)
- metadata-service/plugin/build.gradle (1 hunks)
- metadata-service/plugin/src/main/java/com/datahub/plugins/metadata/aspect/SpringPluginFactory.java (1 hunks)
- metadata-service/plugin/src/test/java/com/datahub/plugins/metadata/aspect/SpringPluginFactoryTest.java (1 hunks)
- metadata-service/plugin/src/test/java/com/datahub/plugins/metadata/aspect/test/TestSpringPluginConfiguration.java (1 hunks)
- metadata-service/plugin/src/test/resources/test-entity-registry-plugins-1.yml (1 hunks)
- metadata-service/plugin/src/test/resources/test-entity-registry-spring-plugins-1.yml (1 hunks)
Additional comments not posted (15)
metadata-service/plugin/build.gradle (2)
24-24: Approval ofspringBootTestdependency.The addition of
springBootTestaligns with the enhancements to Spring-related testing functionalities.
22-23: Approve addition oftest-modelsdependencies.The inclusion of
test-modelswith a specific configurationtestDataTemplateis appropriate for providing tailored models for testing. Ensure these dependencies are correctly integrated into the testing setup.metadata-service/plugin/src/test/resources/test-entity-registry-spring-plugins-1.yml (3)
4-16: Well-defined configuration foraspectPayloadValidators.The detailed configuration for various operations and entity aspects ensures comprehensive testing of the plugin's capabilities.
17-28: Appropriate configuration formutationHooks.This configuration provides a robust setup for testing mutation hooks across different operations and entity aspects.
29-52: Configuration formclSideEffectsandmcpSideEffectsapproved.These configurations are crucial for testing the new side effect functionalities in various scenarios. Verify their correct application in the respective tests.
metadata-service/plugin/src/test/resources/test-entity-registry-plugins-1.yml (3)
18-43: Well-defined configuration foraspectPayloadValidators.The detailed configuration for various operations and entity aspects ensures comprehensive testing of the plugin's capabilities.
44-51: Appropriate configuration formutationHooks.This configuration provides a robust setup for testing mutation hooks across different operations and entity aspects.
52-67: Configuration formclSideEffectsandmcpSideEffectsapproved.These configurations are crucial for testing the new side effect functionalities in various scenarios. Verify their correct application in the respective tests.
entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/config/PluginConfiguration.java (1)
30-34: Correct implementation ofisEmptymethod.The method efficiently checks if all plugin configurations are empty using short-circuiting logic. This is a useful enhancement for easily verifying the presence of configured plugins.
metadata-service/plugin/src/test/java/com/datahub/plugins/metadata/aspect/test/TestSpringPluginConfiguration.java (4)
14-29: Well-configuredspringValidator1bean.The method correctly sets up a
TestValidatorwith detailed configurations for operations and entity aspects, ensuring thorough testing.
32-48: Appropriately broad configuration inspringValidator2.This method extends the testing scope by configuring a
TestValidatorfor all entities, which is beneficial for broader validation scenarios.
52-67: Correct configuration forspringMutator.This method sets up a
TestMutatorwith configurations for multiple operations, ensuring comprehensive testing of mutation functionalities.
70-106: Well-configured side effect beansspringMCPSideEffectandspringMCLSideEffect.These methods correctly set up side effects for specific entities and operations, facilitating comprehensive testing of new functionalities.
metadata-service/plugin/src/test/java/com/datahub/plugins/metadata/aspect/SpringPluginFactoryTest.java (1)
51-123: Comprehensive Test Coverage for Merged Entity RegistryThis test method
testMergedEntityRegistryWithSpringPluginFactoryprovides comprehensive coverage for the functionality of merging entity registries with Spring plugin factory configurations. It checks for the correct merging of entity and event specs, as well as the application of aspect payload validators and mutation hooks.entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/PluginFactory.java (1)
175-181: Validate isEmpty Method LogicThe
isEmptymethod checks if the plugin factory has no configured plugins. The use ofOptionaland stream operations is appropriate here, but ensure that this method accurately reflects the state of the factory, considering all types of plugins (validators, hooks, side effects).Verification successful
Validate isEmpty Method Logic
The
isEmptymethod in thePluginFactoryclass accurately checks if the factory has no configured plugins by verifying thatpluginConfiguration,aspectPayloadValidators,mutationHooks,mclSideEffects, andmcpSideEffectsare empty. The use ofOptionalandList::isEmptyis appropriate and correctly implemented.
pluginConfigurationis checked directly for emptiness.aspectPayloadValidators,mutationHooks,mclSideEffects, andmcpSideEffectsare checked usingOptional.ofNullable(...).map(List::isEmpty).orElse(true).The method accurately reflects the state of the factory.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the isEmpty method logic is accurate. # Test: Search for the function usage. Expect: Only occurances of the new signature. rg --type java $'isEmpty'Length of output: 66746
Script:
#!/bin/bash # Extract the definition of the PluginFactory class and its attributes to verify the isEmpty method's logic. ast-grep --lang java --pattern $'class PluginFactory { $_ }' --multiLength of output: 268
Script:
#!/bin/bash # Extract the definition of the PluginFactory class and its attributes to verify the isEmpty method's logic. ast-grep --lang java --pattern $'class PluginFactory { $_ }'Length of output: 63
Script:
#!/bin/bash # Search for the definition of the PluginFactory class and its attributes to verify the isEmpty method's logic. rg 'class PluginFactory' -A 20Length of output: 2604
Script:
#!/bin/bash # Search for the definition of the PluginFactory class and its attributes to verify the isEmpty method's logic. rg 'class PluginFactory' -A 100Length of output: 13033
| final List<T> plugins; | ||
| if (config.getSpring().getName() == null) { | ||
| plugin = (T) springApplicationContext.getBean(clazz); | ||
| plugins = | ||
| springApplicationContext.getBeansOfType(clazz).values().stream() | ||
| .map(plugin -> (T) plugin) | ||
| .collect(Collectors.toList()); | ||
| } else { | ||
| plugin = (T) springApplicationContext.getBean(config.getSpring().getName(), clazz); | ||
| plugins = | ||
| List.of((T) springApplicationContext.getBean(config.getSpring().getName(), clazz)); | ||
| } | ||
|
|
||
| if (plugin.enabled()) { | ||
| result.add((T) plugin.setConfig(config)); | ||
| } | ||
| plugins.stream() | ||
| .filter(plugin -> plugin.enabled()) | ||
| .forEach( | ||
| plugin -> { | ||
| if (plugin.getConfig() != null) { | ||
| result.add(plugin); | ||
| } else { | ||
| result.add((T) plugin.setConfig(config)); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Refactor Suggestion: Streamline Plugin Collection Logic
The logic for collecting plugins from the Spring context is sound, but it can be streamlined for better readability and performance. Consider using a single stream operation for both cases (with and without specific names) to reduce redundancy and improve maintainability.
- final List<T> plugins;
- if (config.getSpring().getName() == null) {
- plugins =
- springApplicationContext.getBeansOfType(clazz).values().stream()
- .map(plugin -> (T) plugin)
- .collect(Collectors.toList());
- } else {
- plugins =
- List.of((T) springApplicationContext.getBean(config.getSpring().getName(), clazz));
- }
-
- plugins.stream()
- .filter(plugin -> plugin.enabled())
- .forEach(
- plugin -> {
- if (plugin.getConfig() != null) {
- result.add(plugin);
- } else {
- result.add((T) plugin.setConfig(config));
- }
- });
+ List<T> plugins = config.getSpring().getName() == null
+ ? springApplicationContext.getBeansOfType(clazz).values().stream()
+ .map(plugin -> (T) plugin)
+ .collect(Collectors.toList())
+ : List.of((T) springApplicationContext.getBean(config.getSpring().getName(), clazz));
+
+ result.addAll(plugins.stream()
+ .filter(plugin -> plugin.enabled())
+ .map(plugin -> plugin.getConfig() != null ? plugin : (T) plugin.setConfig(config))
+ .collect(Collectors.toList()));Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| final List<T> plugins; | |
| if (config.getSpring().getName() == null) { | |
| plugin = (T) springApplicationContext.getBean(clazz); | |
| plugins = | |
| springApplicationContext.getBeansOfType(clazz).values().stream() | |
| .map(plugin -> (T) plugin) | |
| .collect(Collectors.toList()); | |
| } else { | |
| plugin = (T) springApplicationContext.getBean(config.getSpring().getName(), clazz); | |
| plugins = | |
| List.of((T) springApplicationContext.getBean(config.getSpring().getName(), clazz)); | |
| } | |
| if (plugin.enabled()) { | |
| result.add((T) plugin.setConfig(config)); | |
| } | |
| plugins.stream() | |
| .filter(plugin -> plugin.enabled()) | |
| .forEach( | |
| plugin -> { | |
| if (plugin.getConfig() != null) { | |
| result.add(plugin); | |
| } else { | |
| result.add((T) plugin.setConfig(config)); | |
| } | |
| }); | |
| List<T> plugins = config.getSpring().getName() == null | |
| ? springApplicationContext.getBeansOfType(clazz).values().stream() | |
| .map(plugin -> (T) plugin) | |
| .collect(Collectors.toList()) | |
| : List.of((T) springApplicationContext.getBean(config.getSpring().getName(), clazz)); | |
| result.addAll(plugins.stream() | |
| .filter(plugin -> plugin.enabled()) | |
| .map(plugin -> plugin.getConfig() != null ? plugin : (T) plugin.setConfig(config)) | |
| .collect(Collectors.toList())); |
| @BeforeTest | ||
| public void disableAssert() { | ||
| PathSpecBasedSchemaAnnotationVisitor.class | ||
| .getClassLoader() | ||
| .setClassAssertionStatus(PathSpecBasedSchemaAnnotationVisitor.class.getName(), false); | ||
| } |
There was a problem hiding this comment.
Consider Improving Test Setup Method
The method disableAssert is used to disable assertions for a specific class loader. While this might be necessary for certain tests, disabling assertions globally can lead to missing out on potential issues during testing. Consider limiting the scope of this change or documenting why it is necessary.
| /* | ||
| * Various test plugins to be injected with Spring | ||
| */ | ||
| @Getter | ||
| @Setter | ||
| @Accessors(chain = true) | ||
| public static class TestValidator extends AspectPayloadValidator { | ||
|
|
||
| public AspectPluginConfig config; | ||
|
|
||
| @Override | ||
| protected Stream<AspectValidationException> validateProposedAspects( | ||
| @Nonnull Collection<? extends BatchItem> mcpItems, | ||
| @Nonnull RetrieverContext retrieverContext) { | ||
| return mcpItems.stream().map(i -> AspectValidationException.forItem(i, "test error")); | ||
| } | ||
|
|
||
| @Override | ||
| protected Stream<AspectValidationException> validatePreCommitAspects( | ||
| @Nonnull Collection<ChangeMCP> changeMCPs, @Nonnull RetrieverContext retrieverContext) { | ||
| return Stream.empty(); | ||
| } | ||
| } | ||
|
|
||
| @Getter | ||
| @Setter | ||
| @Accessors(chain = true) | ||
| public static class TestMutator extends MutationHook { | ||
| public AspectPluginConfig config; | ||
| } | ||
|
|
||
| @Getter | ||
| @Setter | ||
| @Accessors(chain = true) | ||
| public static class TestMCPSideEffect extends MCPSideEffect { | ||
|
|
||
| public AspectPluginConfig config; | ||
|
|
||
| @Override | ||
| protected Stream<ChangeMCP> applyMCPSideEffect( | ||
| Collection<ChangeMCP> changeMCPS, @Nonnull RetrieverContext retrieverContext) { | ||
| return changeMCPS.stream(); | ||
| } | ||
|
|
||
| @Override | ||
| protected Stream<MCPItem> postMCPSideEffect( | ||
| Collection<MCLItem> mclItems, @Nonnull RetrieverContext retrieverContext) { | ||
| return Stream.of(); | ||
| } | ||
| } | ||
|
|
||
| @Getter | ||
| @Setter | ||
| @Accessors(chain = true) | ||
| public static class TestMCLSideEffect extends MCLSideEffect { | ||
| public AspectPluginConfig config; | ||
|
|
||
| @Override | ||
| protected Stream<MCLItem> applyMCLSideEffect( | ||
| @Nonnull Collection<MCLItem> batchItems, @Nonnull RetrieverContext retrieverContext) { | ||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
Add More Specific Tests for Plugin Classes
While the test classes for various plugins (validators, mutators, side effects) are defined here, consider adding more specific unit tests to verify the behavior of these plugins under different conditions. This will ensure that each plugin behaves as expected in isolation and when integrated into the system.
Would you like assistance in creating additional unit tests for these plugin classes?
| @Test | ||
| public void testUnloadedMerge() throws EntityRegistryException { | ||
| ConfigEntityRegistry configEntityRegistry1 = | ||
| new ConfigEntityRegistry( | ||
| TestEntityProfile.class.getClassLoader().getResourceAsStream(REGISTRY_FILE_1), | ||
| (config, classLoaders) -> new PluginFactory(config, classLoaders)); | ||
| ConfigEntityRegistry configEntityRegistry2 = | ||
| new ConfigEntityRegistry( | ||
| TestEntityProfile.class.getClassLoader().getResourceAsStream(REGISTRY_FILE_2), | ||
| (config, classLoaders) -> new PluginFactory(config, classLoaders)); | ||
|
|
||
| MergedEntityRegistry mergedEntityRegistry = new MergedEntityRegistry(configEntityRegistry1); | ||
| mergedEntityRegistry.apply(configEntityRegistry2); | ||
|
|
||
| assertEquals( | ||
| mergedEntityRegistry.getAllAspectPayloadValidators().stream() | ||
| .filter(p -> p.getConfig().getSupportedOperations().contains("DELETE")) | ||
| .count(), | ||
| 1); | ||
| assertEquals( | ||
| mergedEntityRegistry.getAllMutationHooks().stream() | ||
| .filter(p -> p.getConfig().getSupportedOperations().contains("DELETE")) | ||
| .count(), | ||
| 1); | ||
| assertEquals( | ||
| mergedEntityRegistry.getAllMCLSideEffects().stream() | ||
| .filter(p -> p.getConfig().getSupportedOperations().contains("DELETE")) | ||
| .count(), | ||
| 1); | ||
| assertEquals( | ||
| mergedEntityRegistry.getAllMCPSideEffects().stream() | ||
| .filter(p -> p.getConfig().getSupportedOperations().contains("DELETE")) | ||
| .count(), | ||
| 1); | ||
| } |
There was a problem hiding this comment.
Review Logic for Unloaded Merges Test
The testUnloadedMerge method tests the behavior of merging registries when plugins are not pre-loaded. This is a critical functionality to ensure robustness in dynamic environments. The implementation seems correct, but consider adding more detailed assertions to verify the exact state of the registry after the merge, especially focusing on the plugins' states.
| @Test | ||
| public void testEmptyMerges() throws EntityRegistryException { | ||
| ConfigEntityRegistry configEntityRegistry1 = | ||
| new ConfigEntityRegistry( | ||
| TestEntityProfile.class.getClassLoader().getResourceAsStream(REGISTRY_FILE_1)); | ||
| ConfigEntityRegistry emptyEntityRegistry = | ||
| new ConfigEntityRegistry( | ||
| TestEntityProfile.class.getClassLoader().getResourceAsStream(REGISTRY_FILE_2), | ||
| (config, classLoaders) -> PluginFactory.empty()); | ||
|
|
||
| MergedEntityRegistry mergedEntityRegistry = new MergedEntityRegistry(configEntityRegistry1); | ||
| mergedEntityRegistry.apply(emptyEntityRegistry); | ||
| assertEquals(mergedEntityRegistry.getPluginFactory(), configEntityRegistry1.getPluginFactory()); | ||
|
|
||
| MergedEntityRegistry mergedEntityRegistry2 = new MergedEntityRegistry(emptyEntityRegistry); | ||
| mergedEntityRegistry2.apply(configEntityRegistry1); | ||
| assertEquals( | ||
| mergedEntityRegistry2.getPluginFactory(), configEntityRegistry1.getPluginFactory()); | ||
| } |
There was a problem hiding this comment.
Tip
Codebase Verification
Ensure Correctness of Test for Empty Merges
The testEmptyMerges method is crucial for ensuring that merging an empty registry does not alter the state of an existing registry. While some null handling is present in the constructors of ConfigEntityRegistry and PluginFactory, the MergedEntityRegistry lacks explicit null checks and error handling. To enhance robustness, consider adding these safeguards, particularly in MergedEntityRegistry.
- ConfigEntityRegistry: Constructors handle nullable parameters.
- MergedEntityRegistry: Lacks explicit null checks and error handling.
- PluginFactory: Handles null
PluginConfigurationby defaulting toPluginConfiguration.EMPTY.
Suggested Enhancements:
- Add null checks and error handling in
MergedEntityRegistryto ensure robustness against edge cases.
Analysis chain
Ensure Correctness of Test for Empty Merges
The method testEmptyMerges is crucial for ensuring that merging an empty registry does not alter the state of an existing registry. The logic appears correct, but it's important to ensure that all edge cases are covered, such as potential null pointers or unexpected behavior when merging configurations.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify all edge cases for empty merges are covered.
# Test: Search for the function usage. Expect: Only occurances of the new signature.
rg --type java $'testEmptyMerges'
Length of output: 181
Script:
#!/bin/bash
# Description: Verify edge cases for empty merges, including null pointers and unexpected behavior handling.
# Search for null checks and error handling in PluginsTest.java
rg --type java 'null' entity-registry/src/test/java/com/linkedin/metadata/aspect/plugins/PluginsTest.java
# Search for error handling (e.g., try-catch blocks) in PluginsTest.java
rg --type java 'try\s*\{' entity-registry/src/test/java/com/linkedin/metadata/aspect/plugins/PluginsTest.java
Length of output: 217
Script:
#!/bin/bash
# Description: Verify constructors and relevant methods of involved classes for null checks and error handling.
# Search for constructors in ConfigEntityRegistry
rg --type java 'ConfigEntityRegistry\s*\('
# Search for constructors in MergedEntityRegistry
rg --type java 'MergedEntityRegistry\s*\('
# Search for constructors and methods in PluginFactory
rg --type java 'PluginFactory\s*\('
Length of output: 14188
Script:
#!/bin/bash
# Description: Extract and review constructors and methods of involved classes for null checks and error handling.
# Extract constructors of ConfigEntityRegistry
rg --type java --context 10 'public ConfigEntityRegistry\s*\(' entity-registry/src/main/java/com/linkedin/metadata/models/registry/ConfigEntityRegistry.java
# Extract constructors of MergedEntityRegistry
rg --type java --context 10 'public MergedEntityRegistry\s*\(' entity-registry/src/main/java/com/linkedin/metadata/models/registry/MergedEntityRegistry.java
# Extract constructors and methods of PluginFactory
rg --type java --context 10 'public PluginFactory\s*\(' entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/PluginFactory.java
Length of output: 6134
| public boolean hasLoadedPlugins() { | ||
| return Stream.of( | ||
| this.aspectPayloadValidators, | ||
| this.mutationHooks, | ||
| this.mcpSideEffects, | ||
| this.mcpSideEffects) | ||
| .anyMatch(Objects::nonNull); | ||
| } |
There was a problem hiding this comment.
Check for Loaded Plugins Consistency
The hasLoadedPlugins method is crucial for determining if the factory has loaded any plugins. The logic here uses a stream to check for non-null lists of different plugin types. Consider adding more detailed logging to trace the loading process and help diagnose issues in environments where plugins might fail to load.
| testCompileOnly externalDependency.lombok | ||
| testAnnotationProcessor externalDependency.lombok |
There was a problem hiding this comment.
Clarify the dual inclusion of Lombok in test dependencies.
Lombok is included as both testImplementation and testCompileOnly. Typically, Lombok should only be needed as testCompileOnly unless there's a specific reason for this configuration.
|
Odd test failure needs investigation |
* added additional tests * added the ability for Spring Plugin class to produce multiple plugin beans
david-leifker
force-pushed
the
plugin-factory-merge
branch
from
62fb66e
to
79df379
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/PluginFactory.java (3 hunks)
- entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/config/PluginConfiguration.java (1 hunks)
- entity-registry/src/test/java/com/linkedin/metadata/aspect/plugins/PluginsTest.java (1 hunks)
- metadata-service/plugin/build.gradle (1 hunks)
- metadata-service/plugin/src/main/java/com/datahub/plugins/metadata/aspect/SpringPluginFactory.java (1 hunks)
- metadata-service/plugin/src/test/java/com/datahub/plugins/metadata/aspect/SpringPluginFactoryTest.java (1 hunks)
- metadata-service/plugin/src/test/java/com/datahub/plugins/metadata/aspect/test/TestSpringPluginConfiguration.java (1 hunks)
- metadata-service/plugin/src/test/resources/test-entity-registry-plugins-1.yml (1 hunks)
- metadata-service/plugin/src/test/resources/test-entity-registry-spring-plugins-1.yml (1 hunks)
Files skipped from review as they are similar to previous changes (9)
- entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/PluginFactory.java
- entity-registry/src/main/java/com/linkedin/metadata/aspect/plugins/config/PluginConfiguration.java
- entity-registry/src/test/java/com/linkedin/metadata/aspect/plugins/PluginsTest.java
- metadata-service/plugin/build.gradle
- metadata-service/plugin/src/main/java/com/datahub/plugins/metadata/aspect/SpringPluginFactory.java
- metadata-service/plugin/src/test/java/com/datahub/plugins/metadata/aspect/SpringPluginFactoryTest.java
- metadata-service/plugin/src/test/java/com/datahub/plugins/metadata/aspect/test/TestSpringPluginConfiguration.java
- metadata-service/plugin/src/test/resources/test-entity-registry-plugins-1.yml
- metadata-service/plugin/src/test/resources/test-entity-registry-spring-plugins-1.yml
Checklist
Summary by CodeRabbit
New Features
isEmpty()andhasLoadedPlugins(), enhancing the plugin management experience.Bug Fixes
Tests
Chores