Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): fix redshift query urns + reduce memory usage #10691

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jun 12, 2024

Fixes a regression from #10619. In reality, it's not a full regression but rather an existing bug that the above PR exposed.

Also improves memory usage, which should help with #10435.

Also bumps avro-gen3, which should improve the performance of the codegen'd classes a bit.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Fixes a regression from #10619. In reality, it's not a full regression but rather an existing bug that the above PR exposed.

Also improves memory usage, which should help with #10435.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 12, 2024
@hsheth2 hsheth2 requested a review from treff7es June 12, 2024 16:57
@hsheth2
Copy link
Collaborator Author

hsheth2 commented Jun 13, 2024

Airflow tests are broken due to #10613 - merging despite that

@hsheth2 hsheth2 merged commit 6329153 into master Jun 13, 2024
58 of 59 checks passed
@hsheth2 hsheth2 deleted the redshift-query-urns branch June 13, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants