docs(ingest): Rename csv / s3 / file source and sink #10675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
asikowitz
commented
Jun 11, 2024
Comment on lines
+151
to
+156
| delete 'sphinx/venv' | ||
| delete 'sphinx/_build' | ||
| delete 'versioned_docs' | ||
| delete fileTree(dir: 'genDocs', exclude: '.gitignore') | ||
| delete fileTree(dir: 'docs', exclude: '.gitignore') | ||
| delete fileTree(dir: 'genStatic', exclude: '.gitignore') |
There was a problem hiding this comment.
Deleting files that are not persisted by git
.gitignore
Outdated
Comment on lines
129
to
131
| datahub-executor/ | ||
| datahub-integrations-service/ | ||
| metadata-ingestion-modules/ |
There was a problem hiding this comment.
Think this is fine to include? Tired of seeing these directories when switching repos
There was a problem hiding this comment.
should be metadata-ingestion-modules/acryl-cloud
Comment on lines
+262
to
+263
| "deltalake>=0.6.3, != 0.6.4, < 0.18.0; platform_system == 'Darwin' and platform_machine == 'arm64'", | ||
| "deltalake>=0.6.3, != 0.6.4; platform_system != 'Darwin' or platform_machine != 'arm64'", |
There was a problem hiding this comment.
Seems like 0.18.0 is broken on ARM macs. Can alternately just forbid version 0.18.0 but may run into the same issue on the next version
There was a problem hiding this comment.
can we also link to the issue delta-io/delta-rs#2577
hsheth2
approved these changes
Jun 11, 2024
.gitignore
Outdated
Comment on lines
129
to
131
| datahub-executor/ | ||
| datahub-integrations-service/ | ||
| metadata-ingestion-modules/ |
There was a problem hiding this comment.
should be metadata-ingestion-modules/acryl-cloud
Comment on lines
+262
to
+263
| "deltalake>=0.6.3, != 0.6.4, < 0.18.0; platform_system == 'Darwin' and platform_machine == 'arm64'", | ||
| "deltalake>=0.6.3, != 0.6.4; platform_system != 'Darwin' or platform_machine != 'arm64'", |
There was a problem hiding this comment.
can we also link to the issue delta-io/delta-rs#2577
hsheth2
added
the
merge-pending-ci
hsheth2
changed the title
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist