Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): DataProcessInstance.emit_process_end() ignored start_timestamp_millis #10539

Merged
merged 2 commits into from
May 24, 2024
Merged

fix(ingest): DataProcessInstance.emit_process_end() ignored start_timestamp_millis #10539

merged 2 commits into from
May 24, 2024

Conversation

obaltian
Copy link
Contributor

The high-level method DataProcessInstance.emit_process_end() actually ignores start_timestamp_millis, which can be passed further to calculate durationMillis instead of using None. This change makes emitter use this argument and save durationMillis.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@obaltian
fix(ingest): use prev.ignored arg in DataProcessInstance
a038a82 
The high-level method DataProcessInstance.emit_process_end() actually ignores  start_timestamp_millis, which can be passed further to calculate durationMillis instead of using None.
This change makes emitter use this argument and save durationMillis.
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels May 19, 2024
@obaltian obaltian changed the title fix(ingest): use prev.ignored arg in DataProcessInstance fix(ingest): DataProcessInstance.emit_process_end() ignored start_timestamp_millis May 19, 2024
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label May 22, 2024
@hsheth2 hsheth2 merged commit c308a6f into datahub-project:master May 24, 2024
58 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@obaltian @sleeperdeep
fix(ingest): DataProcessInstance.emit_process_end() ignored start_tim…
cc63ec0 
…estamp_millis (datahub-project#10539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obaltian @hsheth2