-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker/quickstart): Adding in support for overriding the conflue… #10533
feat(docker/quickstart): Adding in support for overriding the conflue… #10533
Conversation
…nt image and version. datahub-project#10532
WalkthroughThe recent modifications across several Docker Compose files introduced the use of environment variables for specifying the Docker image versions of Kafka, Schema Registry, and Zookeeper. This enhancement facilitates flexibility and customization in configuring and updating the Docker images based on user-defined versions or defaults. Changes
Sequence Diagram(s)Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- docker/quickstart/docker-compose-m1.quickstart.yml (3 hunks)
- docker/quickstart/docker-compose-without-neo4j-m1.quickstart.yml (3 hunks)
- docker/quickstart/docker-compose-without-neo4j.quickstart.yml (3 hunks)
- docker/quickstart/docker-compose.quickstart.yml (3 hunks)
Files skipped from review due to trivial changes (4)
- docker/quickstart/docker-compose-m1.quickstart.yml
- docker/quickstart/docker-compose-without-neo4j-m1.quickstart.yml
- docker/quickstart/docker-compose-without-neo4j.quickstart.yml
- docker/quickstart/docker-compose.quickstart.yml
…nt image and version.
Checklist
Summary by CodeRabbit