Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker/quickstart): Adding in support for overriding the conflue… #10533

Merged

Conversation

brbrown25
Copy link
Contributor

@brbrown25 brbrown25 commented May 17, 2024

…nt image and version.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

  • New Features
    • Updated Docker image versions for Kafka, Schema Registry, and Zookeeper to be configurable through environment variables in all quickstart Docker Compose files.
    • Enhanced flexibility by allowing users to specify custom Docker images and Confluent versions.

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels May 17, 2024
@jjoyce0510 jjoyce0510 enabled auto-merge (squash) June 28, 2024 21:29
@jjoyce0510 jjoyce0510 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 28, 2024
Copy link
Contributor

coderabbitai bot commented Jul 1, 2024

Walkthrough

The recent modifications across several Docker Compose files introduced the use of environment variables for specifying the Docker image versions of Kafka, Schema Registry, and Zookeeper. This enhancement facilitates flexibility and customization in configuring and updating the Docker images based on user-defined versions or defaults.

Changes

Files Change Summary
docker/.../docker-compose-m1.quickstart.yml Updated Kafka, Schema Registry, and Zookeeper images to use environment variables for image versioning.
docker/.../docker-compose-without-neo4j-m1.quickstart.yml Applied environment variables for flexibility in defining image versions of Kafka, Schema Registry, and Zookeeper.
docker/.../docker-compose-without-neo4j.quickstart.yml Implemented dynamic references to environment variables for the Kafka, Schema Registry, and Zookeeper image versions.
docker/.../docker-compose.quickstart.yml Incorporated environment variables for selecting Kafka, Schema Registry, and Zookeeper images based on specified versions or defaults.

Sequence Diagram(s)

Poem

As Docker sails with winds of change,
Environment variables our paths arrange.
Kafka, Zookeeper, Schema share,
In flexible configurations, they fare.
To the horizon, the ship sets pace,
With version control in the right place. 🚀💻


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ae4ca4b and e0bf2fa.

Files selected for processing (4)
  • docker/quickstart/docker-compose-m1.quickstart.yml (3 hunks)
  • docker/quickstart/docker-compose-without-neo4j-m1.quickstart.yml (3 hunks)
  • docker/quickstart/docker-compose-without-neo4j.quickstart.yml (3 hunks)
  • docker/quickstart/docker-compose.quickstart.yml (3 hunks)
Files skipped from review due to trivial changes (4)
  • docker/quickstart/docker-compose-m1.quickstart.yml
  • docker/quickstart/docker-compose-without-neo4j-m1.quickstart.yml
  • docker/quickstart/docker-compose-without-neo4j.quickstart.yml
  • docker/quickstart/docker-compose.quickstart.yml

@jjoyce0510 jjoyce0510 merged commit 9c5bea3 into datahub-project:master Jul 1, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants