Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web-react): add encoder to support non-ASCII characters csv download #10496

Merged
merged 3 commits into from
Jun 28, 2024
Merged

refactor(web-react): add encoder to support non-ASCII characters csv download #10496

merged 3 commits into from
Jun 28, 2024

Conversation

PeamThom
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels May 14, 2024
jjoyce0510
jjoyce0510 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jjoyce0510 jjoyce0510 merged commit 71e79ba into datahub-project:master Jun 28, 2024
1 check failed
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@PeamThom @yoonhyejin
refactor(web-react): add encoder to support non-ASCII characters csv…
94700ed 
… download (#10496)
aviv-julienjehannet pushed a commit to aviv-julienjehannet/datahub that referenced this pull request Jul 17, 2024
@PeamThom @aviv-julienjehannet
refactor(web-react): add encoder to support non-ASCII characters csv…
979c400 
… download (datahub-project#10496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeamThom @jjoyce0510