Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): avoid nested gradle commands #10198

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(build): avoid nested gradle commands #10198

merged 1 commit into from
Apr 4, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 3, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 3, 2024
@hsheth2 hsheth2 requested a review from treff7es April 4, 2024 18:54
treff7es
treff7es approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hsheth2 hsheth2 merged commit f38b626 into master Apr 4, 2024
60 of 61 checks passed
@hsheth2 hsheth2 deleted the nested-gradle branch April 4, 2024 19:46
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@hsheth2 @sleeperdeep
fix(build): avoid nested gradle commands (datahub-project#10198)
a521676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es