fix(ci): flaky smoke test fix (#5569)

datahub-project · Aug 4, 2022 · 2eef7e4 · 2eef7e4
1 parent f984585
commit 2eef7e4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/smoke-test/tests/cypress/cypress.json b/smoke-test/tests/cypress/cypress.json
@@ -4,6 +4,7 @@
   "viewportHeight": 960,
   "viewportWidth": 1536,
   "projectId": "hkrxk5",
+  "defaultCommandTimeout": 10000,
   "retries": {
     "runMode": 2,
     "openMode": 0

diff --git a/smoke-test/tests/cypress/cypress/integration/mutations/mutations.js b/smoke-test/tests/cypress/cypress/integration/mutations/mutations.js
@@ -1,6 +1,7 @@
 describe('mutations', () => {
   before(() => {
     // warm up elastic by issuing a `*` search
+    cy.login();
     cy.visit('http://localhost:9002/search?query=%2A');
     cy.wait(5000);
   });
@@ -118,7 +119,7 @@ describe('mutations', () => {
       // verify dataset shows up in search now
       cy.contains('of 1 result').click();
       cy.contains('cypress_logging_events').click();
-      cy.contains('CypressTestAddTag2').within(() => cy.get('span[aria-label=close]').click());
+      cy.contains('CypressTestAddTag2').within(() => cy.get('span[aria-label=close]').trigger('mouseover', {force: true}).click());
       cy.contains('Yes').click();
 
       cy.contains('CypressTestAddTag2').should('not.exist');

diff --git a/smoke-test/tests/cypress/integration_test.py b/smoke-test/tests/cypress/integration_test.py
@@ -24,10 +24,12 @@ def test_run_cypress(frontend_session, wait_for_healthchecks):
     record_key = os.getenv("CYPRESS_RECORD_KEY")
     if record_key:
         print('Running Cypress tests with recording')
-        command = f"NO_COLOR=1 npx cypress run --record"
+        command = "NO_COLOR=1 npx cypress run --record"
     else:
         print('Running Cypress tests without recording')
-        command = f"NO_COLOR=1 npx cypress run"
+        command = "NO_COLOR=1 npx cypress run"
+        # Add --headed --spec '**/mutations/mutations.js' (change spec name)
+        # in case you want to see the browser for debugging
     proc = subprocess.Popen(command, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE, cwd="tests/cypress")
     stdout = proc.stdout.read()
     stderr = proc.stderr.read()