simple mode f #11
Merged
simple mode f #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Oct 7, 2024
| @@ -122,7 +122,7 @@ where | |||
| } | |||
| std::cmp::Ordering::Equal => { | |||
| max_value = match max_value { | |||
| Some(ref current_max_value) if value < current_max_value => Some(*value), | |||
| Some(ref current_max_value) if value > current_max_value => Some(*value), | |||
There was a problem hiding this comment.
Previously, we returned the MIN value for native types and the first encountered value for strings when multiple values had the same frequency. Now, MAX is used for both, but we can go with MIN in both cases, by the way.
| DataType::Utf8 => Box::new(BytesModeAccumulator::<i32>::new(OutputType::Utf8)), | ||
| DataType::LargeUtf8 => Box::new(BytesModeAccumulator::<i64>::new(OutputType::Utf8)), | ||
| DataType::Utf8View => Box::new(BytesViewModeAccumulator::new(OutputType::Utf8View)), | ||
| DataType::Utf8 | DataType::Utf8View | DataType::LargeUtf8 => Box::new(BytesModeAccumulator::new(data_type)), |
src/common/mode/bytes.rs
Outdated
| V: ArrayAccessor<Item = &'a str>, | ||
| { | ||
| for value in ArrayIter::new(array).flatten() { | ||
| let key = value.to_string(); |
There was a problem hiding this comment.
if you can avoid converting the value to a string here it would likely be significantly faster (it would avoid allocating on each row)
So maybe you could only call to_string() right before you insert into the map
alamb
approved these changes
Oct 7, 2024
|
😍 |
|
Thanks @dmitrybugakov |
|
Thank you for the review, @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10