Merge branch 'main' into burn-the-dead

dataform-co · Jan 4, 2023 · 0b7c0c8 · 0b7c0c8
2 parents c0bf24b + 2348d34
commit 0b7c0c8
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 63 deletions.
diff --git a/WORKSPACE b/WORKSPACE
@@ -184,6 +184,21 @@ gcloud_sdk(
 
 # Go dependencies.
 
+go_repository(
+    name = "org_golang_google_grpc",
+    build_file_proto_mode = "disable",
+    importpath = "google.golang.org/grpc",
+    sum = "h1:rRYRFMVgRv6E0D70Skyfsr28tDXIuuPZyWGMPdMcnXg=",
+    version = "v1.27.0",
+)
+
+go_repository(
+    name = "org_golang_x_net",
+    importpath = "golang.org/x/net",
+    sum = "h1:2mqDk8w/o6UmeUCu5Qiq2y7iMf6anbx+YA8d1JFoFrs=",
+    version = "v0.0.0-20191002035440-2ec189313ef0",
+)
+
 go_repository(
     name = "org_golang_x_text",
     importpath = "golang.org/x/text",

diff --git a/examples/backwards_compatibility/BUILD b/examples/backwards_compatibility/BUILD
diff --git a/examples/backwards_compatibility/dataform.json b/examples/backwards_compatibility/dataform.json
diff --git a/examples/backwards_compatibility/definitions/example.sql b/examples/backwards_compatibility/definitions/example.sql
diff --git a/examples/backwards_compatibility/definitions/example_assertion.assert.sql b/examples/backwards_compatibility/definitions/example_assertion.assert.sql
diff --git a/examples/backwards_compatibility/includes/macros.js b/examples/backwards_compatibility/includes/macros.js
diff --git a/examples/backwards_compatibility/package.json b/examples/backwards_compatibility/package.json
diff --git a/go.mod b/go.mod
diff --git a/tests/api/BUILD b/tests/api/BUILD
@@ -4,8 +4,6 @@ ts_test_suite(
     name = "tests",
     srcs = glob(["**/*.ts"]),
     data = [
-        "//examples/backwards_compatibility:files",
-        "//examples/backwards_compatibility:node_modules",
         "//examples/common_v2:files",
         "//examples/common_v2:node_modules",
         "//examples/formatter:files",

diff --git a/tests/api/examples.spec.ts b/tests/api/examples.spec.ts
@@ -753,21 +753,6 @@ suite("examples", () => {
     }
   });
 
-  test("backwards_compatibility", async () => {
-    const graph = await compile({ projectDir: "examples/backwards_compatibility" });
-
-    const tableNames = graph.tables.map((t: dataform.ITable) => t.target.name);
-
-    // Make sure it compiles.
-    expect(tableNames).includes("example");
-    const example = graph.tables.filter((t: dataform.ITable) => t.target.name === "example")[0];
-    expect(example.type).equals("table");
-    expect(example.query.trim()).equals("select 1 as foo_bar");
-
-    // Make sure we can dry run.
-    new Builder(graph, {}, { tables: [] }).build();
-  });
-
   test("times out after timeout period during compilation", async () => {
     try {
       await compile({ projectDir: "examples/never_finishes_compiling" });