Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of populated elements should not be always same #980

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

snuyanzin
Copy link
Collaborator

This allows to have different elements in collection of populated objects and should fix #979

@what-the-diff
Copy link

what-the-diff bot commented Oct 2, 2023

PR Summary

  • Modification in Java Object Transformer
    The logic of retrieving and creating objects based on their class type has been updated. This was accomplished by removing the existing CLASS2RESULT map in the JavaObjectTransformer.java file. This update provides a more direct and efficient approach to object manipulation.

  • Addition of New Test Method in Fake Annotation Test
    A new test method, named shouldGenerateEntityWithDefaultSchemaAndInDefaultSchemaInCurrentClass2, was added to the FakeAnnotationTest.java file. This method is designed to generate a list of DefaultPerson objects using a custom schema. This enhancement will help us in efficiently testing our code by ensuring that our object generation is correctly implemented and reliable.

@bodiam
Copy link
Contributor

bodiam commented Oct 2, 2023

Thanks for fixing!

@bodiam bodiam merged commit 440f371 into datafaker-net:main Oct 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Object transformation to list
2 participants