Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up SvSe number validation #927

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Speed up SvSe number validation #927

merged 1 commit into from
Aug 21, 2023

Conversation

snuyanzin
Copy link
Collaborator

Similar to #926

@what-the-diff
Copy link

what-the-diff bot commented Aug 21, 2023

PR Summary

  • Revise Date/Time Handling in EnZAIdNumber.java
    The existing system-wide date/time variable has been removed from this file, and the parseDate method now uses the new standard date/time format that has been introduced elsewhere.

  • Introduce New Date/Time Format in IdNumbers.java
    A new constant, DATE_TIME_FORMATTER, has been implemented in this file for date/time formatting.

  • Updates in SvSEIdNumber.java
    The parseDate method and validSwedishSsn method have been updated to use new Java time classes instead of older utility classes, adding to the standardization and efficiency of our system. Additionally, the error-catching element of the validSwedishSsn method has been broadened to effectively respond to any exception, as opposed to only ParseException.

@snuyanzin snuyanzin merged commit 6269e3f into datafaker-net:main Aug 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snuyanzin