Refactor country-specific properties #1489
Open
+1,044
−560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move country-specific properties from
lang.yml
to_COUNTRY.yml
files.These are settings that depend on country, not language (e.g. postal code, building numbers, passport numbers, internet domains).
The primary test showing the difference is
AddressTest.usingOnlyCountryCodeWithoutLanguage()
.For example,
And:
In this PR, I had to introduce concept of "language's default country".
In the case when only the language is given, we need to detect the country:
The list of "language's default countries" is located in
FakerContext.LANGUAGE_DEFAULT_COUNTRY
.