Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add movie name to movie provider #1442

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

hardikSinghBehl
Copy link
Contributor

This PR adds the below method to the existing movie provider:

  • new Faker().movie().name();

Functionality has been validated and tested locally.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (562ceed) to head (b8a7921).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1442      +/-   ##
============================================
- Coverage     92.26%   92.25%   -0.02%     
  Complexity     3166     3166              
============================================
  Files           320      320              
  Lines          6182     6183       +1     
  Branches        593      593              
============================================
  Hits           5704     5704              
  Misses          338      338              
- Partials        140      141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bodiam bodiam merged commit cbe3105 into datafaker-net:main Nov 18, 2024
10 checks passed
@bodiam
Copy link
Contributor

bodiam commented Nov 18, 2024

Nice one, thanks!

@hardikSinghBehl hardikSinghBehl deleted the feature/movie-name branch November 18, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants