Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add greek translations for Ancient provider #1404

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

gvrettos
Copy link
Contributor

Of course, ancient gods from Greek mythology could not be left outside of Greek translations, so I added them. 😉

Could you also annotate this PR with hacktoberfest-accepted label?

Copy link

what-the-diff bot commented Oct 24, 2024

PR Summary

  • Expanded Collection of Ancient Greek God Names
    The el-GR locale has been enriched with a vast range of ancient Greek god names, enhancing the dimension of diversity and context. They are conveniently classified into three categories: ancient, primordial, and titan.

  • Introduction of a 'Hero' Category
    A new segment named 'hero' has been integrated, presenting a plethora of famed names such as "Αχιλλέας", "Ηρακλής", and "Οδυσσέας". This addition will provide more options and depth when referring to heroic figures.

  • Preservation of the 'Greek Philosophers' Section
    The current section that contains Greek philosophers hasn't been disturbed during this update, retaining titles like "Πλάτων". This helps to ensure that we are not losing information while adding more.

@kingthorin
Copy link
Collaborator

I’ll put together a fix for the test failure, it is unrelated to these changes.

[ForkJoinPool-1-worker-4] 22:46:34.129398 INFO [FakerIntegrationTest] Finished tests - OK (memory used:309, free:381, total:691, max:1792)
22:46:36.352 [ERROR] Failures: 
22:46:36.352 [ERROR]   UniversityTest.testName:16 
Expecting actual:
  "South Yost University of Liège"
to match pattern:
  "[A-Za-z'() ]+"

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (848dfe7) to head (c11dadf).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1404      +/-   ##
============================================
+ Coverage     92.19%   92.21%   +0.01%     
  Complexity     3151     3151              
============================================
  Files           319      319              
  Lines          6152     6152              
  Branches        593      593              
============================================
+ Hits           5672     5673       +1     
+ Misses          336      334       -2     
- Partials        144      145       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin kingthorin merged commit 6c10e43 into datafaker-net:main Oct 24, 2024
12 checks passed
@gvrettos gvrettos deleted the feature/ancient-el_GR branch October 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants