Merge pull request #1332 from datafaker-net/refactoring/simplify-en-file

simplify EnFile: don't collect a static list that is needed only once

src/main/java/net/datafaker/service/FakeValuesGrouping.java

@@ -14,9 +14,9 @@ public class FakeValuesGrouping implements FakeValuesInterface {
     private final Map<String, Collection<FakeValuesInterface>> fakeValues = new HashMap<>();
 
     static {
-        for (EnFile file : EnFile.getFiles()) {
+        EnFile.getFiles().forEach(file -> {
             ENGLISH_FAKE_VALUE_GROUPING.add(FakeValues.of(FakeValuesContext.of(Locale.ENGLISH, file.getFile(), file.getPath())));
-        }
+        });
     }
 
     public void add(FakeValuesInterface fakeValue) {

src/main/java/net/datafaker/service/files/EnFile.java

@@ -1,12 +1,10 @@
 package net.datafaker.service.files;
 
-import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 import java.util.stream.Stream;
 
 public class EnFile {
-    public static final String YML = ".yml";
+    private static final String YML = ".yml";
     private final String file;
     private final String path;
 
@@ -260,7 +258,7 @@ public String getPath() {
         "zodiac.yml").map(EnFile::new).toList();
 
     // files where the search path can't be derived from the filename
-    private static final List<EnFile> FILES_WITH_A_DIFFERENT_PATH = Arrays.asList(
+    private static final List<EnFile> FILES_WITH_A_DIFFERENT_PATH = List.of(
         new EnFile("animal.yml", "creature"),
         new EnFile("cat.yml", "creature"),
         new EnFile("dog.yml", "creature"),
@@ -294,14 +292,7 @@ public String getPath() {
         new EnFile("observation.yml", "healthcare")
     );
 
-    private static final List<EnFile> ALL_FILES;
-
-    static {
-        ALL_FILES = new ArrayList<>(FILES);
-        ALL_FILES.addAll(FILES_WITH_A_DIFFERENT_PATH);
-    }
-
-    public static List<EnFile> getFiles() {
-        return ALL_FILES;
+    public static Stream<EnFile> getFiles() {
+        return Stream.concat(FILES.stream(), FILES_WITH_A_DIFFERENT_PATH.stream());
     }
 }