Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added individual test case docstring support and tests #51

Merged
merged 4 commits into from
Jun 25, 2018
Merged

Added individual test case docstring support and tests #51

merged 4 commits into from
Jun 25, 2018

Conversation

palakpsheth
Copy link

Added ability to define doc per each test case similar to name attribute

@codecov-io
Copy link

codecov-io commented Jul 19, 2017 •
edited
Loading

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #51   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         111    116    +5     
=====================================
+ Hits          111    116    +5
Impacted Files Coverage Δ
ddt.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5b144...9c9fc56. Read the comment docs.

txels
txels reviewed Oct 7, 2017
View reviewed changes
Copy link
Collaborator

@txels txels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and a thousand apologies for not having looked at it earlier.

In general the contribution seems good. Would you mind adding some documentation about this feature?

test/test_functional.py
setattr(Mytest, 'test_hello', data_hello)

ddt_mytest = ddt(Mytest)
assert_is_not_none(getattr(getattr(ddt_mytest, 'test_hello_1_case1'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not assert_equals or something more precise? You know the value you should expect...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@wswld wswld merged commit 84a7527 into datadriventests:master Jun 25, 2018
@wswld
Copy link
Contributor

wswld commented Jun 25, 2018

@palakpsheth sorry for the wait, merging for now, but I'm going to clean up it a bit myself later.

wswld added a commit that referenced this pull request Jul 17, 2018
@wswld
#51 update tests and docs for docstring handling
8803732
@wswld
Copy link
Contributor

wswld commented Jul 17, 2018

Fixed the issues with docs and tests. This is up for the next release.

wswld added a commit that referenced this pull request Jul 17, 2018
@wswld
#51 fix flake8
189642e
@palakpsheth
Copy link
Author

palakpsheth commented Jul 17, 2018 via email

openstack-gerrit pushed a commit to openstack/manila that referenced this pull request Jul 23, 2018
@gouthampacha
[Docs] Don't include unittest documentation
2b389ce 
The `test_quota` and `test_policy` modules
don't need to be documented, since they present
no meaningful information to contributors.

Removing these also avoids the docstring
formatting issues that ddt may introduce
to the sphinx build. [1]

[1] datadriventests/ddt#51

Change-Id: I8136e8a000e04bcc213a746c7d793bf9373b1b38
Closes-Bug: #1783124
openstack-gerrit pushed a commit to openstack/openstack that referenced this pull request Jan 3, 2019
@openstack-gerrit
Update git submodules
363ba30 
* Update manila from branch 'master'
  - Merge "QNAP: driver should not manage snapshot which does not exist"
  - Drop param2id() from cmd/manage.py
    
    The function is not used anywhere.
    
    Change-Id: I799e73992faa387e56a793d60cc599039d268f81
    
  - QNAP: driver should not manage snapshot which does not exist
    
    The snapshot which does not exist in NAS shuold not be managed.
    
    Change-Id: I06475ccc507ee62f3da8f8795694f6da14064036
    Closes-Bug: #1810374
    
  - Drop is_eventlet_bug105() from manila/utils.py
    
    The function is not used anywhere.
    
    Change-Id: I9dd7aedec35c6295e764301e7f5a81a126de85df
    
  - Merge "[DevRef] Add code review guideline"
  - Merge "QNAP: Support QES FW on TDS series NAS"
  - Merge "Adjust ssh timeouts"
  - Merge "Add devstack instructions and local.conf samples"
  - QNAP: Support QES FW on TDS series NAS
    
    Support both QTS and QES FW on TDS series NAS models.
    
    Change-Id: I87129fae531b6d50b8490785badcb054a9dd9397
    
  - Adjust ssh timeouts
    
    Generic driver jobs are failing because of timeouts when
    establishing the initial ssh connection from manila-share
    to the service VM.
    
    Bump up the default value of the connection timeout for paramiko
    client and also set the banner timeout since the failure occurred
    during banner exchange.  Set the two timeouts to the same value
    for now.  This ensures that the connection timeout is at least as
    long as the banner timeout and there is no current need in manila
    to control these independently.
    
    This is more of a workaround than a real fix since a real fix
    would remove the delay during banner exchange.  I suspect that
    the real fix will need to be in neutron/ovs though.
    
    Change-Id: Ib5e59faaf9667b9cb5e7d4072531b7d6c3d4da39
    Partial-bug: #1807216
    
  - Merge "[doc] Fix api sections in the contributor doc"
  - Merge "[Manila Unity/VNX] add 'snapshot support' related Doc for Unity/VNX driver"
  - Add devstack instructions and local.conf samples
    
    Restructure the development environment documentation
    and include sample devstack config to get folks
    started easy when they're coding manila changes.
    
    Change-Id: If2df8bdf88e77eec32e8795020b8ef349b55b41b
    
  - [doc] Fix api sections in the contributor doc
    
    Weed out outdated/unnecessary info and add link
    to api ref.
    
    Change-Id: Ia45c8ad6e2a697d5b76232e17e4df34539d81c12
    
  - Set ram for manila service image to 256
    
    At 192 with ubuntu bionic SVMs with this service image
    crash at boot with OOM condition.
    
    Change-Id: I75d0a39bf83c384f902d3e30e223fb0bd363d840
    
  - Merge "Deprecate old keystone session config opts"
  - [Manila Unity/VNX] add 'snapshot support' related Doc for Unity/VNX driver
    
    Change-Id: I76c8b31c890e5f8d7beeddc6b8ab1a3a0731bcfb
    
  - Deprecate old keystone session config opts
    
    In the past, the options ca_certificates_file,
    nova_ca_certificates_file, cinder_ca_certificates_file,
    api_insecure, nova_api_insecure, cinder_api_insecure
    were supplied to instantiate nova, neutron and cinder
    clients. These options have now been subsumed in a more
    generic way into the Keystone session logic as 'cafile'
    and 'insecure'. Deprecate the older options in Stein so
    that we can remove them in a future release.
    
    This deprecation began many releases ago when we switched
    to using keystone sessions [1]. However, we were still
    overriding the values of "insecure" and "cafile" if provided,
    forcing users to continue using deprecated parameters
    "api_insecure" and "ca_certificates_file". So despite
    this fix originating in the Stein release, it would be
    prudent to backport it to all maintained releases and
    remove support for these older options in/beyond Train
    release (9.0.0).
    
    [1] Ic211a11308a3295409467efd88bff413482ee58d
    Change-Id: I148e9079c7c1ab119f519f727d4ad97758473325
    Related-Bug: #1802393
    Closes-Bug: #1809318
    
  - Merge "Only run the needed services for CephFS jobs"
  - Fix image_name retrieval in custom-image jobs
    
    And use a 'file://' url for the custom manila image.
    
    See also https://review.openstack.org/#/c/623330.  These
    are interdependent patches but no harm is done by merging
    this one first and having 623330 depend on it since retrieval
    of the image name is not working correctly anyways.
    
    Partial-Bug: #1807969
    
    Change-Id: Ib3a74d170f159dfbc38b5302f00800f3530f4921
    
  - Only run the needed services for CephFS jobs
    
    These jobs often fail due to timeouts so only enable the services
    required for devstack tests with these back ends.
    
    Change-Id: Ib620ec3c2a9999ea9908a7c23aa7172c40a4cbd9
    
  - Merge "NetApp ONTAP: cifs add AD security service server as preferred DC"
  - Use the canonical URL for Manila repositories
    
    - When the URL refers to cloning or using git repositories, use the
      cloning URL (https://git.openstack.org/openstack/<project>)
    - When the URL refers to the browsable version of the repository, use
      the cgit frontend (https://git.openstack.org/cgit/openstack/<project>)
    
    Change-Id: I11a8e15c6d663786465c090b40db9e20b19194e6
    
  - Merge "fix http link to https link"
  - fix http link to https link
    
    Change-Id: I07e1a7ed99a79b774a7a7ba58f407972f3b724c3
    
  - NetApp ONTAP: cifs add AD security service server as preferred DC
    
    multiple comma separated entries can be given
    
    Change-Id: I9d6c79704d0ceb7a6fdc18035992e707327dd908
    Closes-Bug: #1804651
    
  - Change openstack-dev to openstack-discuss
    
    Mailinglists have been updated. Openstack-discuss replaces openstack-dev.
    
    Change-Id: I344871839f124239f2c7079934c5b4119609b99d
    
  - Merge "Fix ganesha for 0.0.0.0/0 access"
  - Merge "VMAX manila doc - use of correct VMAX tags"
  - Merge "VMAX manila doc - support for IPv6"
  - Merge "Remove i18n.enable_lazy() translation"
  - Fix ganesha for 0.0.0.0/0 access
    
    Translate '0.0.0.0/0' to '0.0.0.0' when allowing IP
    access with the ganesha driver since the ganesha back end
    cannot handle the former expression and the latter has
    the desired effect of allowing access to all IPs.
    
    Closes-bug: #1800627
    
    Change-Id: Ica698b6a70a128522c2c2de76a69e59207fd60ac
    
  - Merge "Add missing ws separator between words"
  - Merge "[api-ref] Added share servers show and corrected path to details"
  - Add missing ws separator between words
    
    This is to add missing ws separator between words.
    
    Change-Id: I8b471b87c6a12783a6b8bf56ec1523103f471090
    
  - Merge "[CI][LVM] Run the LVM job on Bionic Beaver"
  - Merge "NeutronBindNetworkPlugin: fix multi segment neutron data save."
  - VMAX manila doc - support for IPv6
    
    VMAX manila drivers support for IPv6.
    
    Change-Id: I759b1a5ccb2a315fe4e7b9a17e023ad50a92ac81
    
  - [api-ref] Added share servers show and corrected path to details
    
    Change-Id: Idc0fbd9f786b50dd4899258337aa5bcb61c4ab0a
    Closes-Bug: #1795604
    
  - [CI][LVM] Run the LVM job on Bionic Beaver
    
    We switched to running the voting LVM driver job
    from Ubuntu to CentOS because the "nfs-utils"
    package on Ubuntu 16.04 lacked two bug-fixes [1][2]
    required to test IPv6 exports. The kernel
    package has been updated on Ubuntu 18.04 [3]
    and the latest package has these fixes.
    
    Switching back to Ubuntu will also help us
    move faster towards our python3-first goal
    since there are no plans to support python3
    in the CentOS base repositories.
    
    [1] http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=4663c6481c294838260840d234fec7dfd3186451
    [2] http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=188354e57dd8476e66ce30d647180a106da29b88
    [3] https://launchpad.net/nfs-utils/+packages
    
    Depends-On: https://review.openstack.org/#/c/611199/
    Depends-On: https://review.openstack.org/#/c/604929/
    Depends-On: https://review.openstack.org/#/c/614802/
    Change-Id: I8928f7ef87b0ec53a6a65f5d8964b2eee885056d
    
  - [LVM][IPv6] Quagga changes to support Bionic Beaver
    
    Pre-create config and log directories and
    update Quagga service configuration.
    
    This patch does not add Bionic support to the gate
    jobs. https://review.openstack.org/#/c/608761/ does
    the job configuration changes to run with Bionic.
    
    Needed-By: https://review.openstack.org/#/c/608761/
    Change-Id: I146ab5a41c06df2b2615ebdb38aaeb972db4c1d2
    
  - Merge "NetApp ONTAP: Fix use of multiple subnets with DHSS=True"
  - Merge "Use OS CLI instead of the neutronclient"
  - Merge "[CI] Switch Xenial tempest jobs to Bionic Beaver"
  - Use OS CLI instead of the neutronclient
    
    In the DevStack plugin.
    
    Change-Id: I338634ab5e6360f4399d1df66c9ba3c9ba6c5ddf
    
  - Merge "VMAX manila - deprecate old tags correctly"
  - Remove i18n.enable_lazy() translation
    
    Lazy translation of messages is not used in OpenStack [1].
    This causes problems for commands which use translatable messages.
    The lazy translation effort was abandoned several years ago.
    
    [1] http://lists.openstack.org/pipermail/openstack-dev/2018-November/136289.html
    
    Change-Id: I25a9ec0a96b7c57f8a6928c0537bf133f6b6931c
    
  - Delete the duplicate words in  cephfs_driver.rst
    
    Change-Id: Ic70dca4122b0210352279529d98bf5f637bb7eb8
    
  - The URL of SSL is missing
    
    Change-Id: I082bcdaaa396092594451e2d5122ecbfef5abc3c
    
  - [DevRef] Add code review guideline
    
    Clarify the manila code review guidelines
    in the developer docs. This document evolved
    as part of the discussions at the Denver PTG [1]
    and the manila community meeting on 4th Oct 2018 [2].
    
    [1] https://etherpad.openstack.org/p/manila-ptg-planning-denver-2018
    [2] http://eavesdrop.openstack.org/meetings/manila/2018/manila.2018-10-04-15.01.log.txt
    
    Change-Id: I953ac9c1ef641db13a4f0165a7b74e447641a7f4
    
  - [Trivial Fix] Correct spelling error of "throughput"
    
    Small modification to correct spelling mistake.
    
    Change-Id: I4aa1c3cbcc7b14c5b0ecf4957d344dd71f8decb2
    
  - [CI] Switch Xenial tempest jobs to Bionic Beaver
    
    This change specifically ignores the grenade
    job (manila-grenade), which is pending conversion
    to zuulv3 because we need a way to set the default
    python3 interpreter when running on Bionic Beaver.
    
    Depends-On: https://review.openstack.org/#/c/605291/
    Depends-On: https://review.openstack.org/#/c/605242/
    Depends-On: https://review.openstack.org/#/c/605810/
    Change-Id: Ic49d4ac5ac36dd3b3d909941434b2d2f104a10b9
    
  - VMAX manila - deprecate old tags correctly
    
    Aligning with VNX/Unity terminology in
    https://github.com/openstack/manila/commit/966b1621d3be351b8ab5c831a2688a997b8281c8
    Old tags were replaced without deprecating correctly.  Also adding a
    release note for this change
    
    Change-Id: If180f1a2ea8c307c8a40f2a17b35796357306c03
    Closes-Bug: #1798393
    
  - inspur: transfer 'rw' to 'rwx' when Shared File Systems protocol is cifs
    
    'rw' means is read\write\create\delete file in manila.
    But it is only read\write file in AS13000.
    The 'rwx' in AS13000 does the same thing as 'rw' in manila.
    
    Co-Authored-By: Brin Zhang <[email protected]>
    
    Closes-Bug: #1797291
    Change-Id: Id1453e86f3179ef5bca3e349c6e7c58ff7f991c8
    
  - Merge "[LVM] Run filesystem check before assigning UUID"
  - NeutronBindNetworkPlugin: fix multi segment neutron data save.
    
    Neutron subnet data can be obtained directly and is needed to get
    ip_version for port creation. Network data needs to wait for port
    binding.
    Fixes 2b40e5618f2c1039bbbbd1a3e31b72e104b5436b error:
    "Can not find any IP address with configured IP version None in
    share-network".
    
    Closes-Bug: #1747695
    Change-Id: Ie6c8a26db5c461400b789f91a97eb7ccc1031a0f
    
  - NetApp ONTAP: Fix use of multiple subnets with DHSS=True
    
    NetApp ONTAP Multi-SVM driver was raising an error while trying to
    create shares on multiple subnets that belong to the same neutron
    network, as it was trying to map multiple ipspaces to the same VLAN
    port.
    
    This fix allows the driver to use the same ipspace and VLAN port across
    all subnets belonging to the same neutron network.
    
    Change-Id: If9cbb34a890ee44806c404085e40cc924a1296a7
    Closes-Bug: #1774159
    
  - VMAX manila doc - use of correct VMAX tags
    
    https://review.openstack.org/#/c/608725/ now aligns terminology with VNX and
    Unity.  Updating he documentation accordingly.
    
    Change-Id: I9dc91a48daed9779b02068b4fdd05a07227135dc
    
  - Add manila-status upgrade check command framework
    
    This adds basic framework for manila-status upgrade
    check commands. For now it has only "check_placeholder"
    check implemented.
    Real checks can be added to this tool in the future.
    
    Change-Id: Id809535d0a01617916a8e29f151ca4e61f738fad
    Story: 2003657
    Task: 26139
    
  - Merge "change tox envlist from 3.5 to 3"
  - Merge "NetApp ONTAP fix test allocate container with share_instance"
  - [LVM] Run filesystem check before assigning UUID
    
    We assign a random UUID with tune2fs to snapshots
    and shares created from snapshots so that they
    don't conflict with the parent shares/snapshots
    when both of them are being mounted.
    
    tune2fs requires that a filesystem check be
    performed "recently" before UUID assignments.
    So, perform a filesystem check right away to
    allow tune2fs to assign a random UUID.
    
    Change-Id: I858a318f7a83e033cc3f2699859e38b6b74c8d24
    Related-Bug: #1645751
    Closes-Bug: #1798219
    
  - Merge "Fix ShareGroup sqlalchemy model ShareGroupTypes relation."
  - Merge "Simplify running pylint"
  - Merge "Increment versioning with pbr instruction"
  - Merge "Change python3.5 job to python3.7 job on Stein+"
  - Change python3.5 job to python3.7 job on Stein+
    
    python3.5 was the only supported python3 version
    on Xenial, now that we have Bionic Beaver nodes
    that support python3.7, lets switch to testing
    with python3.7 in addition with python3.6 in
    Stein and beyond.
    
    See ML discussion here [1] for context.
    
    [1] http://lists.openstack.org/pipermail/openstack-dev/2018-October/135632.html
    
    Change-Id: Ia9868f39ff788e02850fae756820f7c1388bde0a
    Depends-On: https://review.openstack.org/#/c/609832/
    Story: #2004073
    Task: #27427
    
  - Increment versioning with pbr instruction
    
    With moving away from required milestone releases, the version numbers
    calculated by PBR on the master branch will not work for those testing
    upgrades from the last stable release. More details can be found in the
    mailing list post here:
    
        http://lists.openstack.org/pipermail/openstack-dev/2018-October/135706.html
    
    This is an empty commit that will cause PBR to increment its calculated
    version to get around this.
    
    PBR will see the following which will cause it to increment the version:
    
    Sem-Ver: feature
    
    Please merge this patch as soon as possible to support those testing
    upgrades.
    
    Change-Id: Ifff1ad9627e0f369e99b90ab9deea3f12a661b36
    Signed-off-by: Sean McGinnis <[email protected]>
    
  - Make coverage non-voting and fix use of rpc_backend
    
    rpc_backend was an old oslo_messaging option
    that was deprecated in stable/newton and removed
    in master/stein [2], so stop using it in our
    unit tests.
    
    The coverage job in manila was always non-voting,
    however, a773e31420bfd141682c43d0823d2009078c2fec
    added a common coverage job-template from the
    openstack-zuul-jobs repository. This change
    inadvertently made the non-voting cover job a
    voting job.
    
    Our coverage script isn't perfect, it is known
    to fail erroneously on non-code changes, and
    some genuine failures are just an indication
    to developers and reviewers to make the best
    effort to adhere to the script's strict
    checks [3].
    
    These changes are unrelated, but must be fixed
    together to pass the gate, since we have a
    chicken-and-egg problem with both failures
    preventing separate fixes from merging
    separately.
    
    [1] https://review.openstack.org/#/c/317285/
    [2] https://review.openstack.org/#/c/580910/
    [3] http://git.openstack.org/cgit/openstack/manila/tree/tools/cover.sh
    
    Closes-Bug: #1796759
    Related-Bug: #1797512
    Change-Id: Ie349c3866d51ea4e706369ad67bc1155f62f2651
    
  - Simplify running pylint
    
    This commit does several things:
    
    - Setup and run pylint directly rather than running through a script.
      This allows the user to see what is happening while the user is running
      through pylint.
    - Allow the user to either run pylint on a particular changeset,
      or the entire manila tree.
    - Allow the user to run on a particular changeset. Using like HEAD~1,
      etc.
    - I disabled the tests that were reported by pylint.
      The thought here would be go through the failures
      and correct them.
    - Update pylint to 2.1.1.
    
    Change-Id: I398d1ba01a3fd7f1c86ad4065a7984d276f33383
    Signed-off-by: Chuck Short <[email protected]>
    
  - Merge "Don't quote {posargs} in tox.ini"
  - Merge "[grenade] Switch base version"
  - Don't quote {posargs} in tox.ini
    
    Quotes around {posargs} cause the entire string to be combined into one
    arg that gets passed to stestr. This prevents passing multiple args
    (e.g. '--concurrency=16 some-regex')
    
    Change-Id: I1088cfbab31befbd24e56add806d6e86fe46e5eb
    
  - remove glusterfs-nfs job from check queue
    
    The job never passes, is unmaintained, and
    wastes CI resources.
    
    Change-Id: I05d7ee7f8ed01b98f2ec6cf629af1d5002b2cdbb
    
  - Merge "Adds export path option to Quobyte driver"
  - change tox envlist from 3.5 to 3
    
    base python version is 3, not 3.5 and
    python 3.5 is not installed in some current
    distros so running 'tox' locally fails.
    
    Change-Id: Ie2449a433e07f4cafb55fe1db247ba9f854cef97
    
  - Remove run_tests.sh
    
    It is deprecated in favor of tox.
    
    Closes-Bug: #1790470
    Change-Id: If3b6a274dab0d035b9666b3b9876604cefbc2877
    
  - Merge "Add command to update share instance hosts"
  - Merge "[Container driver] Fix volume group data collection"
  - [grenade] Switch base version
    
    Grenade jobs need to test Rocky-->Stien (dev)
    in the master branch.
    
    Change-Id: Id7664187e1d95920be072cd85ebbb817ef5b087d
    
  - [Container driver] Fix volume group data collection
    
    On different distros, the vgs command may have a
    different format. So, lets ask very specific questions
    about the total and free size, and use that response.
    
    Change-Id: I36e5e3ba7be562846687c7cc989028371efae2fc
    Needed-By: https://review.openstack.org/#/c/604929/
    Closes-Bug: #1794402
    
  - [ZFSOnLinux] Allow devstack bootstrap in Ubuntu > 16.04
    
    The package seems to be present and maintained
    in the ubuntu repositories for all releases
    following Xenial Xerus.
    
    [1] https://packages.ubuntu.com/search?keywords=zfsutils-linux
    
    Change-Id: If212e0482b360f3c3888918242dba6a710ab2818
    Needed-By: https://review.openstack.org/#/c/604929/
    
  - Merge "Add version maximum annotation to API versions doc"
  - 3PAR: Update Storage Driver docs
    
    License will now come along with 3PAR Storage
    
    Change-Id: Idd095fa66c1d23637b17d04ce322633525498617
    
  - Merge "Spelling Errors"
  - Merge "add python 3.6 unit test job"
  - Merge "Use templates for cover and lower-constraints"
  - Remove install-guide-jobs
    
    This job needs to stay in project-config, remove it again.
    
    Change-Id: I2ee0256a06d9efed846ce971666c4f344d877c0c
    
  - Use templates for cover and lower-constraints
    
    Use openstack-tox-cover template, this runs the cover job
    in the check queue only.
    
    Use openstack-lower-constraints-jobs template.
    
    Remove jobs that are part of the templates.
    
    Change-Id: Ia9102cb55bc0093be7c654480084cddf0342b0ae
    
  - Spelling Errors
    
    Change-Id: Ibe705eb6e7896a01cd035101cb4391f7f84efbc6
    
  - Add version maximum annotation to API versions doc
    
    TrivialFix
    
    Change-Id: I476735eac5de5eb987976d05bf756dd8fc669596
    
  - Merge "switch documentation job to new PTI"
  - Merge "import zuul job settings from project-config"
  - Merge "NetApp ONTAP: change cifs server valid dns hostname"
  - Add command to update share instance hosts
    
    usage: manila-manage share update_host --currenthost CURRENTHOST
                                           --newhost NEWHOST
                                            [--force FORCE]
      --currenthost CURRENTHOST  Current share host name.
      --newhost NEWHOST     New share host name.
      --force FORCE         Ignore validations.
    
    A fully qualified host string is of the format
    'HostA@BackendB#PoolC'. The command allows making
    substring modifications to update the host or the
    host and backend. To avoid making gratuitous changes,
    the complete host string must be specified.
    
    Change-Id: I0f30ab6135c8c438860341cc68b512311e9c4711
    
  - Merge "adjust response code in 'service.inc'"
  - add python 3.6 unit test job
    
    This is a mechanically generated patch to add a unit test job running
    under Python 3.6 as part of the python3-first goal.
    
    See the python3-first goal document for details:
    https://governance.openstack.org/tc/goals/stein/python3-first.html
    
    Change-Id: I61388a08a8414a4c77652da2f326a10bfebdfd41
    Story: #2002586
    Task: #24309
    
  - switch documentation job to new PTI
    
    This is a mechanically generated patch to switch the documentation
    jobs to use the new PTI versions of the jobs as part of the
    python3-first goal.
    
    See the python3-first goal document for details:
    https://governance.openstack.org/tc/goals/stein/python3-first.html
    
    Change-Id: I293ac074601ab38836b7f86ac77e9f156956c6ab
    Story: #2002586
    Task: #24309
    
  - import zuul job settings from project-config
    
    This is a mechanically generated patch to complete step 1 of moving
    the zuul job settings out of project-config and into each project
    repository.
    
    Because there will be a separate patch on each branch, the branch
    specifiers for branch-specific jobs have been removed.
    
    Because this patch is generated by a script, there may be some
    cosmetic changes to the layout of the YAML file(s) as the contents are
    normalized.
    
    See the python3-first goal document for details:
    https://governance.openstack.org/tc/goals/stein/python3-first.html
    
    Change-Id: Ibc5dd2e7e6cb1922e9c34a6c0cf5ce8c7a8bf615
    Story: #2002586
    Task: #24309
    
  - Merge "Remove logging overrides from plugin.sh"
  - NetApp ONTAP fix test allocate container with share_instance
    
    Closes-Bug: #1787230
    Change-Id: I13a2fd16b4b3373adb658c4ecfa0dc2e9e5ec7df
    
  - Remove logging overrides from plugin.sh
    
    Avoid overwriting the log formatters, reuse
    the helper available in Devstack.
    
    Closes-Bug: #1787310
    Change-Id: I25eb16ea9a6e3e98de6a7ee349df17438847d601
    
  - adjust response code in 'service.inc'
    
    TrivialFix
    Change-Id: I7c164b1942a485e1206f76d8700135cbb888303c
    
  - Merge "Update reno for stable/rocky"
  - Merge "[ZFSOnLinux] Retry unmounting old datasets during manage"
  - Adds export path option to Quobyte driver
    
    A new option for configuring the export path of
    shares provided by the Quobyte driver is added.
    This allows adapting the export path to the settings
    of the Quobyte NFS servers 'Pseudo' option.
    
    Besides the new option this also fixes a minor
    coding style issue regarding a mutable default
    argument in jsonrpc.py.
    
    Implements: blueprint qb-export-path-option
    Closes-Bug: #1773929
    
    Change-Id: Ibd486c8418469045a0988ef66a1c5cef810d3eae
    
  - Fix manila-ui link in the contributor doc
    
    Change-Id: I3445deb95fc02cc11e3d5fdccb96f577b17acec7
    Closes-Bug: #1658611
    
  - Fix ShareGroup sqlalchemy model ShareGroupTypes relation.
    
    Query for deleted must look for 'False'.
    Fixes manila manage db purge.
    
    Closes-Bug: #1786769
    Change-Id: I6d9966b257553749f73993e6d63951747131b570
    
  - Merge "Test share type per test suite changes"
  - [ZFSOnLinux] Retry unmounting old datasets during manage
    
    Add a retry loop to ensure the dataset being renamed
    is cleanly unmounted before the rename operation.
    
    Change-Id: Ie506f237010c415ee9f0d64abbefd5854f776a5f
    Closes-Bug: #1785180
    
  - Update reno for stable/rocky
    
    Change-Id: Ieb500a78cb05679a589cb6772a31faa958b0caad
    
  - NetApp ONTAP: change cifs server valid dns hostname
    
    by using hyphen instead of dots and underscore
    
    Change-Id: Iba8131fff3d92100d554a07f42f23c7a38c2e469
    Closes-Bug: #1716694
    
  - NetApp cDOT driver switch volume efficiency
    
    cDOT compression requires that deduplication is enabled.
    Reflect that in update_volume_efficiency_attributes
    method, which is now also used for create_volume.
    
    Closes-Bug: #1778022
    Change-Id: I1aa05aa07b1cb64c44b1f654ee77b620b6c5e6d0
    
  - Merge "NetApp cDOT: use security service ou"
  - Merge "NetApp cDOT driver qos policy same name"
  - Merge "replace 'data=' with 'message='"
  - Merge "Fix grenade job"
  - replace 'data=' with 'message='
    
    Replace keyword 'data=' with 'message='
    
    Change-Id: Ic4b0ba3136f27722511cc49bca21568f7b518618
    
  - NetApp cDOT driver qos policy same name
    
    Don't try to rename QoS Policy Group to the name it already has.
    This is an unnecessary operation, that fails on NetApp Api with
    "Reason - 18339:Policy with new name already exists".
    
    Closes-Bug: #1778761
    Change-Id: Iad58131ca6b675a4577888e287cd4899ea257771
    
  - Test share type per test suite changes
    
    Make default share type and group type
    creation optional in
    manila-tempest-minimal-dsvm-dummy job.
    
    Depends-On: https://review.openstack.org/#/c/540070/
    Change-Id: I585c15d9eb4eefb843df62f7aad08838c83611e2
    
  - INFINIDAT: unit tests - remove fake exception body
    
    The class FakeInfinisdkException is used in the tests code to mock the
    exceptions raised by infinisdk (our internal library for connecting to
    the InfiniBox REST API). In earlier versions, this exception was
    implemented by inhereting from the base Exception class and
    implementing its constructor, however, this code is redundant,
    and basic inherithance should do.
    
    Change-Id: I44059d41143eaee6d7dcb073e21c9c840dacae3e
    
  - Fix grenade job
    
    When upgrading from Queens to Rocky,
    since neither release has the tempest plugin in-tree,
    it has to be explicitly installed
    in the job.
    
    Closes-Bug: #1785370
    Change-Id: I77b5e0eb8824a8a00633aacb45ebea07572503d5
    
  - Merge "INFINIDAT: add host.created_by metadata key"
  - Merge "Api-ref: Add min_version in the API parameters"
  - Merge "check all_tenants value in share api"
  - Fix mutable config in manila-scheduler
    
    We had SIGHUP apply the "mutate" behavior to the
    ProcessLauncher with [1], however, the scheduler
    process does not use ProcessLauncher.
    
    Oslo config made "debug" a mutable config option
    in [3]
    
    Closes-Bug: #1785129
    
    [1] I6499ae6c98d9489a123bb20febd6c1ddb9e17b86
    [3] I1e7a69de169cc85f4c09954b2f46ce2da7106d90
    
    Change-Id: Ifffe3cad0f5cd52988ce253794efc5b03ea9840b
    
  - Fix ZFSOnLinux doc about manage ops
    
    Trivial documentation update that was
    discovered when building a scenario test [1]
    for the manage/unmanage operations with
    the ZFSOnLinux driver.
    
    [1] I4245cd202543cfefb0aa4e9c56ab949e2a9821f6
    
    Change-Id: I92e4467319e4d0682581cce83a2f0c959d1b9555
    
  - Merge "Docs: glance image-create returns an error issue"
  - INFINIDAT: add host.created_by metadata key
    
    This patch adds the "host.created_by" metadata key. The metadata value
    indicates the name and version of the INFINIDAT tool which created the
    relevant system object.
    
    TrivialFix
    
    Change-Id: Ib5a78593a30a6b530dade412fab576981a7f2241
    
  - check all_tenants value in share api
    
    add manila.utils.is_all_tenants to check all_tenants value.
    share_networks and security_service api will check all_tenants value
    in the following patches.
    
    Change-Id: I1aa9903276038dc839df45b852b329a75be5657f
    Partial-Bug: #1777551
    Co-Authored-By: Jiao Pengju <[email protected]>
    
  - NetApp cDOT: use security service ou
    
    sets organizational unit in AD at NetApp C-mode CIFS server
    
    Change-Id: Ifbbd98d0ad414985ac15da52d9e3305dd109e927
    Closes-Bug: #1696669
    
  - Merge "QNAP: Add support for QES 2.1.0"
  - Merge "Retrieve is_default value to fix empty display in CLI"
  - Merge "Api-ref: change fix ``extra-spec-key`` key in path"
  - Api-ref: Add min_version in the API parameters
    
    TrivialFix:
    
    Change-Id: Idc29bb1744e4760f72be706c03eb6451465d5d59
    Closes-bug: #1614955
    
  - Retrieve is_default value to fix empty display in CLI
    
    This bug is from path[1], when we use manila client to create
    a share type or share group type, the is_default value is always
    empty, so add the is_default value when we create each share type
    or share group type.
    
    Closes-bug: #1743941
    [1] Ib264d8422fe57701f990cbbf7ea5d1e90b8b0008
    
    Change-Id: Ia8bcb632591fc0b5438847b22ec59c2039ecf5f1
    
  - [Docs] Don't include unittest documentation
    
    The `test_quota` and `test_policy` modules
    don't need to be documented, since they present
    no meaningful information to contributors.
    
    Removing these also avoids the docstring
    formatting issues that ddt may introduce
    to the sphinx build. [1]
    
    [1] https://github.com/datadriventests/ddt/pull/51
    
    Change-Id: I8136e8a000e04bcc213a746c7d793bf9373b1b38
    Closes-Bug: #1783124
    
  - Support metadata for access rule resource
    
    Now only share have metadata property.
    We should support it for access rule as well.
    
    DocImpact
    
    Needed-By: https://review.openstack.org/#/c/579534
    Needed-By: https://review.openstack.org/#/c/571366
    
    Change-Id: I2f2b3325a09e5af7f7c4e4fa3443259fb69f9771
    Implements: bp metadata-for-access-rule
    
  - Merge "Add share instance index on share_id"
  - QNAP: Add support for QES 2.1.0
    
    This patch do the following change to the QNAP Manila driver:
    1. Add support for QNAP QES firmware 2.1.0.
    
    Change-Id: I81320b6af988d19526241fd0856b427fcf1f96d7
    Implements: blueprint qnap-support-qes-210
    
  - [CI] Don't set test config for API microversions if master
    
    If the version's being bumped on manila,
    the newer API changes cause test failures with
    manila-tempest-plugin.
    
    We could carefully craft a
    manila-tempest-plugin changeset that fixes
    any incongruous test assumptions and make the
    manila change depend on the tempest changeset.
    However, that may make developing the API harder
    than it is today.
    
    Change-Id: Ie97fb49b38b565dcc57332db8b42605216372aa8
    Related-Bug: #1781671
    
  - Merge "Manila share driver for Inspur AS13000 series."
  - Merge "[NetApp driver] Control snapshot folder visibility"
  - Merge "Fix ensure_shares bugs"
  - Merge "Api-ref: Add missing parameter in the version api"
  - Merge "Allow setting test API microversions in gate tests"
  - Api-ref: Add missing parameter in the version api
    
    Add missing updated parameter in the version api.
    besides, change media-types parameter in body and
    required.
    
    Change-Id: Ib0123f16a969ecc98f5dccd2a03eab621e02d8c8
    
  - Allow setting test API microversions in gate tests
    
    Add MANILA_TEMPEST_MIN_API_MICROVERSION and
    MANILA_TEMPEST_MAX_API_MICROVERSION to the ci
    post_test_hook. These options default to
    the values specified in the api_version_request.py
    file.
    
    Also add the API Version History to the api-ref.
    
    Change-Id: I21b3a705986216afb0ce73ca1f92571dda757408
    Closes-Bug: #1781671
    
  - Api-ref: change fix ``extra-spec-key`` key in path
    
    TrivialFix:
    In the API Unset an extra spec:
    /v2/{tenant_id}/types/{share_type_id}/extra_specs/{extra-spec-key}
    the key extra-spec-key should be in path, but it is in body, this
    is to fix this.
    
    Change-Id: Ia6f01a6bca369ca4b922a45e8e6ece4f583528c7
    
  - Docs: glance image-create returns an error issue
    
    glance image-create --copy-from command returns an error
    --copy-from is not allowed in glance default v2 version.
    
    Change-Id: Ied78435ae927c8c1b6b92740aca7596950a244ff
    Closes-bug: #1700169
    
  - [NetApp driver] Control snapshot folder visibility
    
    By default, every share created allows access of its .snapshot
    where files of each taken snapshot can be accessed. As per
    some use-cases, it is desirable to not allow access to
    the .snapshot folder.
    
    This can now be done by using the extra_spec netapp:hide_snapdir.
    When set to True, it will hide the .snapshot directory for every
    newly created share.
    
    Also, for existing shares, a config option named
    netapp_reset_snapdir_visibility can be used to reset
    all existing shares' setting to either hide or display
    the .snapshot visibility on driver restarts.
    
    Implements blueprint: netapp-snapdir-visibility
    Change-Id: I30619bb13de528538b9887b00f39482f91a8db49
    
  - Fix results capturing for the dummy driver
    
    Tempest moved to running under stestr from
    testr [1] and the subunit2html installation
    has been altered as well [2].
    
    [1] https://review.openstack.org/#/c/504345/
    [2] https://review.openstack.org/#/c/534431/
    
    Change-Id: I615fa6d4362f83f35e40a750bfcb3a96cc193f35
    
  - Fix ensure_shares bugs
    
    Fixed bugs that caused ensure_shares to not work properly. Mainly:
    
    - Comparison between db object and hash string was causing
      ensure_shares to run every time. Fixed by reading property
      'info_hash' of db object.
    - Driver implementation of ensure_shares would raise an
      exception in case of returning None. Fixed by adding
      'or {}' to method invocation.
    - Missing share_servers parameter for each share passed
      to ensure_shares. Fixed by converting share_instance
      entities to dictionaries before passing to drivers.
    
    Closes-bug: #1771866
    Closes-bug: #1772644
    Closes-bug: #1772647
    
    Change-Id: Iac969e9cac6cea46deb12f5d8423be592cfeb72a
    
  - Merge "[NetApp driver] NVE License not present fix"
  - Merge "INFINIDAT: change create_child to create_snapshot"
  - Merge "Fix bare exceptions in ganesha manager"
  - [NetApp driver] NVE License not present fix
    
    Since the addition of NVE support in the NetApp ONTAP driver,
    the driver fails to start when a VE license is not present on
    a 9.1 (or later) ONTAP box.
    
    This patch fixes the problem by improving error handling.
    
    Change-Id: I27bf9f0d1be666f4151281ca52d6bb3377f856ff
    Closes-Bug: #1772026
    
  - Change depreciated to deprecated
    
    TrivialFix
    
    Change-Id: Ic68f8e8ae80279fb38b00acbf2784a7301ff51bb
    
  - Fix bare exceptions in ganesha manager
    
    Closes-Bug: #1779922
    Change-Id: Ife18c61c4d195a73980a03287700df7ba9b52b9c
    
  - INFINIDAT: change create_child to create_snapshot
    
    create_child method was deprecated in favor of create_snapshot
    in infinisdk package. This is an internal change and should have
    no customer impact.
    
    Change-Id: I47a29c2223c05e89da4a528350d23a2201751182
    
  - Manila share driver for Inspur AS13000 series.
    
    Features that Inspur AS13000 Driver support:
    share create/delete,
    snapshot create/delete,
    extend size,
    create_share_from_snapshot,
    update_access.
    protocol: nfs/cifs
    ThirdPartySystems: INSPUR CI
    
    Change-Id: If0e1134e80f799186bb7cd057ff0f2d713f39a06
    Implements: Blueprint inspur-as13000-manila-driver
    
  - Add share instance index on share_id
    
    The index on the foreign key is created on InnoDB mysql implicitly.
    This makes it explicit.
    
    Closes-Bug: #1776495
    Change-Id: I6ff5cee86997d0d756b4852fa4d0e7bcfcc9c1cf
    
  - Merge "NetApp cDOT driver skip vserver route with no gateway"
  - Merge "[Manila Unity/VNX] admin doc failed to render"
  - Merge "DB Migration: fix downgrade in 579c267fbb4d"
  - [Manila Unity/VNX] admin doc failed to render
    
    In Dell EMC Unity and VNX admin doc, IPv6 part section failed to render.
    
    Change-Id: I9cfe4681d646cfa7b49ff33c2637cf999d79abd1
    Closes-bug: #1778862
    
  - Merge "Limit formatting routes when adding resources"
  - DB Migration: fix downgrade in 579c267fbb4d
    
    The downgrade incorrectly modifies deleted
    share access rules.
    
    Also add a missing unit test for this migration.
    
    Co-Authored-By: Goutham Pacha Ravi <[email protected]>
    Change-Id: If3700e7a18cbd8ae496b8c503c95cf6723485679
    Closes-Bug: #1717392
    
  - Merge "Address trivial TODOs"
  - Merge "Allow api_version_request.matches to accept a string or None"
  - Merge "Cannot remove user rule for NFS share"
  - Cannot remove user rule for NFS share
    
    Use generic driver create share, then add user type access failed.
    We can not use 'manila access-deny' to delete the user rule
    in a NFS share db.
    This path fix this issue.
    
    Change-Id: I9375c4be9361d593102a382eb9c14c2d776bb1aa
    Closes-Bug:#1591357
    
  - Merge "API: Add ``all_tenants`` parameter"
  - Fix mutable default argument in Quobyte jsonrpc
    
    Change-Id: I03d86c45aed3238cfa82de3eea5bc44c285cc118
    Closes-Bug: #1773929
    
  - Merge "[API] Doc snapshot and share net deletion preconditions"
  - Merge "Use volume_uuid in _resize_share of Quobyte Driver"
  - API: Add ``all_tenants`` parameter
    
    When administrarots query snapshots, share networks, or security
    services, they may set ``all_tenants`` to true to get records for all
    OpenStack projects.
    
    Change-Id: Ia208dec102295f1021ce5c4da88397e7946c8dba
    
  - Merge "[Doc] Add 'gateway' and 'mtu' in share network api-ref"
  - Fix doc warnings
    
    Clean up D000 and D005 warnings on doc build.
    
    Closes-Bug: #1777669
    
    Change-Id: I3c059136850a15a823b7eff83c7837f55a09f734
    
  - [API] Doc snapshot and share net deletion preconditions
    
    1. Share snapshot state must be ``available`` or ``error``.
    2. Share network must not be in use by any shares or share groups.
    
    Change-Id: I4bc81ed3677c8d65059b47b22aec2edbecf2c55f
    
  - Address trivial TODOs
    
    - Add share type access to type view builder
    - Remove unnecessary docstring TODO
    
    TrivialFix
    
    Change-Id: I856a3318f498800eab5932b7ad250621ccf4292f
    
  - Merge "rectify 'a extra specs' to 'an extra specs'"
  - Merge "rectify 'a export ID' to 'an export ID'"
  - NetApp cDOT driver skip vserver route with no gateway
    
    Skip route creation if user decided to configure neutron network
    without a gateway.
    
    Closes-Bug: #1777126
    Change-Id: Ic54e3aa7fc8327464110fff40d02c690d8b19122
    
  - Remove confusing DB deprecation messages
    
    When share instances were introduced a number of fields
    were moved in the database model to the underlying share instance
    and proxied back to the share in order to maintain compatability
    with APIs that assume these to belong to the share.  A deprecation
    warning was added for these.  The warning spams the API log and
    confuses end users because it sounds like they or their client
    should make a change to get rid of them and that cannot actually
    be done.  The API would have to change to expose share instances
    to end users rather than just administrators and that is not
    something that we plan to do.
    
    Remove these confusing warnings.
    
    Closes-Bug: #1776947
    
    Change-Id: I95e99b26f416bbf25cfd1c8f7295f3ba6220efb3
    
  - add release notes to README.rst
    
    Change-Id: Ie838d7e496be75ffd36b69ed637b7f963bcda1ab
    
  - rectify 'a export ID' to 'an export ID'
    
    Change-Id: Ie0db00b5b5f7d7c0760b63c72a105700bb6fc85d
    
  - rectify 'a extra specs' to 'an extra specs'
    
    Change-Id: I96557ac3e782b2306bd2603461949f6dad6e09ea
    
  - rectify 'a exact match' to 'an exact match'
    
    Change-Id: I25abdededdc4e472c83fbda2d10f142b79456ccc
    
  - Merge "Document the preconditions for deleting a share"
  - Merge "[Grenade] Switch base to stable/queens"
  - Document the preconditions for deleting a share
    
    Document both the share status that allows deletion and
    dependencies of the share that prevent share deletion.
    
    Change-Id: I5f076112e66a2d50394639dce50390d8cfb4922b
    
  - Merge "Delete unused test check"
  - Merge "Use class name in invocation of super"
  - Merge "VMAX driver - Implement IPv6 support for Dell EMC VMAX driver"
  - Merge "Fix use of pbr version release"
  - Merge "Switch to oslo_messaging.ConfFixture.transport_url"
  - Merge "[Trivialfix] Remove the useless parameter 'ext_mgr'"
  - Merge "Generic driver - Limiting SSH access from tenant network"
  - Merge "QNAP: driver changes share size when manage share"
  - Use volume_uuid in _resize_share of Quobyte Driver
    
    Adds resolving the volume name to volume id when resizing
    and cleans up _resolve_volume_name calls.
    
    Closes-Bug: #1774604
    
    Change-Id: I37ecd611c94f9b0019b87d5186f96aed93130f88
    
  - Limit formatting routes when adding resources
    
    By default, routes.mapper.Mapper.resource adds a bunch of formatted
    routes that accept anything after a '.'. Our spec says only .xml
    and .json are accepted so limit the formatting to those valuse.
    
    This allows identifiers with a '.' in urls. A few tests were added
    to the extensions test to prove that .xml and .json are stripped
    but other values are not.
    
    It is already modified in cinder [1].
    
    [1] https://bugs.launchpad.net/cinder/+bug/1307956
    
    Change-Id: I91d8aa967446b5d7ce52f1b245149304494777f3
    Closes-bug: #1774353
    
  - Allow api_version_request.matches to accept a string or None
    
    According to the Manila devref you should be able to use the following
    pattern:
    
    if req_version.matches("2.1", "2.5"):
        ....stuff....
    elif req_version.matches("2.6", "2.10"):
        ....other stuff....
    elif req_version > api_version_request.APIVersionRequest("2.10"):
        ....more stuff.....
    
    However, the api_version_request.matches() function will not accept a
    string, it requires an api_version_request object.
    
    Fix this to accept a string, as well as None for object.
    
    Change-Id: Ic2faaaa7696cc7a647679cbb7a8600b30c3d66d7
    Closes-Bug: 1550337
    
  - Update link address
    
    Change-Id: Id8f643de838e570594fda80c2a74348c361db6b7
    
  - Generic driver - Limiting SSH access from tenant network
    
    Added new config option limit_ssh_access. If set to true the
    neutron security groups are set up to block port 22 from other
    subnets than service network in service instance.
    
    Change-Id: I3c247ac2c55e5c74dbb0c8e31144bb865fd48710
    Closes-bug: #1714288
    
  - [Trivialfix] Remove the useless parameter 'ext_mgr'
    
    The parameter 'ext_mgr' is not used in method _setup_routes() in
    subclasses:
    manila.api.v2/router.APIRouter
    manila.api.v1.router.APIRouter
    manila.api.versions.VersionsRouter
    So it should be removed to make the code clean.
    
    The superclass of them is manila.api.openstack.__init__.APIRouter,
    the 'ext_mgr' is removed from method _setup_routers() in superclass.
    
    In method__init__() in superclass, the _setup_routers() is called,
    so 'ext_mgr'is removed in related calling statement.
    
    Change-Id: I25e2d5447b328c88c660ae17025f65719290b21b
    
  - Delete unused test check
    
    TrivialFix
    
    Change-Id: Id93a5062c48e99afc22594f05cbf29cffce2494e
    
  - [Doc] Add 'gateway' and 'mtu' in share network api-ref
    
    The attributes "gateway" and "mtu" are already added in Shared File
    Systems API since version 2.18 and 2.20. This patch provides description
    about them in response parameters, and adds them to response examples.
    
    Change-Id: I55e3a04453a9edd20b5ca4e1627ae8c3ae5601cc
    
  - Merge "Config for cephfs volume path prefix"
  - QNAP: driver changes share size when manage share
    
    After manage share, driver updates the share size.
    The share size should not be updated.
    
    Change-Id: I5f670495cd61b63d1c0669c274b502a6a691e4e2
    Closes-Bug: #1773761
    
  - Merge "Trivial: Update pypi url to new url"
  - Merge "fix tox python3 overrides"
  - Trivial: Update pypi url to new url
    
    Change-Id: I9cec36f7339d74176e0e978e46ee2019d60441a6
    
  - Config for cephfs volume path prefix
    
    The cloud administrator needs to use the cephfs volume path prefix to
    layout multiple cephfs driver backends. When cephfs has multiple
    data pools, manila can configure `cephfs_volume_path_prefix` to store
    volume data in different cephfs directories of a ceph filesystem [1]
    for the different cephfs driver backends. Out of band of manila, the
    admin can set the pool layouts of these cephfs directories to store
    the volume data in different data pools of the ceph filesystem. This
    is helpful for planning different data storage to different ceph OSDs.
    
    [1] https://github.com/ceph/ceph/commit/d1a21b07ede#diff-8625369b924524f064e083e735bd34beR267
    
    Change-Id: I19e3dd55f1fded339cb17222b3333c0c0f8835e9
    Implements: blueprint cephfs-driver-configurable
    
  - Switch to oslo_messaging.ConfFixture.transport_url
    
    oslo_messaging's rpc_backend setting, which is set by
    ConfFixture.transport_driver has been deprecated since Newton. To allow
    oslo_messaging to remove it, switch to setting transport_url instead.
    
    Change-Id: I8ac08a2f966356f14f89c109dbfa0a66c258e939
    Partial-Bug: #1712399
    
  - Use class name in invocation of super
    
    Fix pylint E103 warning raised by usage of
    self.__class__ to refer to the derived class
    in super() methods.
    
    self.__class__ is a reasonable first argument
    to super() in any method of a class, as long
    as the method is not going to be invoked in
    derived classes.
    
    Python3 removes this ambiguity by not requiring
    arguments for the super() method.
    
    [1] https://docs.pylint.org/en/1.6.0/features.html#id33
    
    Change-Id: I6071b6cfd8cff2be3853d739f71b94da990cda97
    
  - Fix use of pbr version release
    
    The "release" member of pbr's VersionInfo
    class was removed when [1] introduced
    Semantic Versioning. Fix the sole usage of
    this member and associated pylint error E1101:
    
    ["Instance of 'VersionInfo' has no 'release' member",
    "return version.version_info.release"]
    
    [1] I482e07cce9b65df452d5b9af4c73960df68a141e
    
    Change-Id: Ia2a241b5ac2ddca29effe3e83df151bec6a76cba
    
  - Default pylint to run using python3
    
    Updates the pylint and lint jobs to run under python3 by
    changing the target python and updating the version of
    pylint used.
    
    Change-Id: Ie0ac158674fb22054b80864d33d9d7ecc82e3b36
    Closes-bug: #1673824
    
  - fix tox python3 overrides
    
    We want to default to running all tox environments under python 3, so
    set the basepython value in each environment.
    
    We do not want to specify a minor version number, because we do not
    want to have to update the file every time we upgrade python.
    
    We do not want to set the override once in testenv, because that
    breaks the more specific versions used in default environments like
    py35 and py36.
    
    Change-Id: I59ac21cb0d34f0b6767c736d0419eb6b874efca1
    Signed-off-by: Doug Hellmann <[email protected]>
    
  - Merge "Switch from ostestr to stestr"
  - Merge "Set initial quota in Quobyte and correct resizing"
  - Merge "Fix share-service VM restart problem"
  - Merge "Fix post-execution for tempest tests"
  - Merge "Fix access control for single host addresses"
  - [Grenade] Switch base to stable/queens
    
    We should test two neighbour branches in grenade job.
    So, after branching of stable/queens we should use it as
    base for testing of manila migration to current master
    branch (Rocky-dev).
    
    Change-Id: I20a78d69b4adcedd2e1691c7ef672567826a6b79
    
  - Set initial quota in Quobyte and correct resizing
    
    Ensure a shares initial quota is set in the backend,
    and do quota size conversion when resizing.
    
    Closes-Bug: #1771958
    Closes-Bug: #1771970
    
    Change-Id: I64a1e591c2682bc8bb62554a95399b5651253f59
    
  - Trivial:Update pypi url to new url
    
    Pypi url changed from [1] to [2]
    
    [1] https://pypi.python.org/pypi/<package>
    [2] https://pypi.org/project/<package>
    
    Change-Id: I1500185f2d152178670d4e14c3479ec273b53f6e
    
  - Fix share-service VM restart problem
    
    The /etc/mtab file may have mount information such as 'nfsd'
    that if copied to /etc/fstab will cause the share server to
    hang when rebooted.
    
    Update /etc/fstab with exactly the newly mounted or unmounted
    shares rather than simply overwriting /etc/fstab with /etc/mtab.
    
    Change-Id: I67602bae1f928769d768008deca7bd0f2fef1ac2
    Close-Bug: #1639662
    
  - Merge "Fix test plugin issues in dsvm-lvm-centos job"
  - Merge "Add ou to security service"
  - Merge "NetApp ONTAP: Fix delete-share for vsadmin users"
  - Fix test plugin issues in dsvm-lvm-centos job
    
    Require running the job with neutron-tempest-plugin
    since neutron-dynamic-routing relies on it,
    and does not specify it in its requirements.
    
    Change-Id: Ic8e8033b77f82c3264270ba042a44177babaff9b
    Closes-Bug: #1772077
    
  - Fix manila-tempest-*-centos-7 jobs
    
    There was a recent change announced on the CentOS
    mailing lists [1] regarding housing centos-release-SIG
    repos for CPU architectures other than x86_64. We rely on
    centos-release-pike within our test jobs and the
    repo centos-qemu-ev is found under [2].
    
    There is now a YUM variable called $contentdir
    which determines where the repos may be, and this
    variable isn't set in the base images.
    
    With $contentdir set, the URLs resolve correctly
    within /etc/yum.repos.d/CentOS-QEMU-EV.repo.
    
    See corresponding fixes for kolla [3] and
    tripleo-quickstart-extras [4]
    
    [1] https://lists.centos.org/pipermail/centos-devel/2018-March/016542.html
    [2] http://mirror.centos.org/centos/7/virt/x86_64/kvm-common
    [3] Ieb26c0aa65ba3ec1a45a33f87f670e5ecb782f82
    [4] I6279bd4088bd87f37c58b7da25b675c5456506d6
    
    Change-Id: Idcacfb6dbfb0760128f10dbc0573856e4250b3bc
    Closes-Bug: #1771969
    
  - VMAX driver - Implement IPv6 support for Dell EMC VMAX driver
    
    This patch delivers support to create, delete, extend, and access NFS
    and CIFS share/ snapshot over an IPv6 network. It also delivers
    support to connect to the VMAX eNAS management interface using an IPv6
    address.
    
    Change-Id: I62183b2dcb536b3058becebf81fe23f6c40aa03b
    Implements: blueprint vmax-manila-ipv6-support
    
  - Fix post-execution for tempest tests
    
    Manila's post_test_hook runs tempest after
    populating tempest.conf with the requisite
    options, the results from tempest are saved
    prior to performing some post tasks, including
    deciding to run tests again with a different
    configuration if necessary
    (Ex: manila-tempest-minimal-dsvm-dummy). The
    result is then replayed at the end of the gate
    job so it can be reported to gerrit as a
    SUCCESS or a FAILURE.
    
    Fix the mis-aligned command that saves the
    test execution status to replay later.
    
    Change-Id: I1578760697aeae6e20bf567c60fbcdee0a642bee
    Closes-Bug: 1770183
    
  - Fix access control for single host addresses
    
    In CIDR notation, the max prefix-length is typically
    used to denote individual host addresses, for example:
    2620:52:0:13b8::fe:e7 and 2620:52:0:13b8::fe:e7/128
    are semantically the same.
    
    Fix the access-allow API to raise 400 Bad Request if
    an address by either notation already exists in the
    manila database for a given share.
    
    Change-Id: I6e790fd0edd82064a3c5cda8a919c9eeb2da85d0
    Closes-Bug: 1767430
    
  - Switch from ostestr to stestr
    
    This change just updates the tox.ini file to call stestr directly
    instead of going through ostestr.
    
    Change-Id: Ibe957cda167b59ef44f5c7e9dfc415c227213565
    
  - Update "auth_url" in install docs
    
    Based on the change in Keystone Install Guide [1],
    this patch replace port 35357 with 5000 for "auth_url" in docs.
    
    For more details, please check similar changes which have been done
    on other projects: Nova [2], Neutron [3], Cinder [4], Glance [5].
    
    [1] https://review.openstack.org/#/c/541857
    [2] https://review.openstack.org/#/c/562812
    [3] https://review.openstack.org/#/c/566491
    [4] https://review.openstack.org/#/c/565464
    [5] https://review.openstack.org/#/c/558932
    
    Change-Id: Ied73662270c56bbeb3a09ae2ad7965de58f6ef8d
    
  - Merge "Fix allow the use of blank in user group name to access the share"
  - NetApp ONTAP: Fix delete-share for vsadmin users
    
    qos- APIs are unavailable to vsadmin users. Fix the
    code in the delete share flow to prevent failing on
    being unable to execute the qos-get-iter call.
    
    Change-Id: If9ce7c840fc968824d53002eaaea082e28631178
    Closes-Bug: 1765420
    
  - Merge "Fix bug for share type filter search"
  - Fix title overline too short when generate docs
    
    when running tox -e docs locally, it failed because
    the title overline too short.
    
    Change-Id: I9b1d85f12ff559e032c465d7737e9c27efb459c3
    Closes-bug: #1769073
    
  - Fix bug for share type filter search
    
    filter results do not take effect. for details, see comments
    in review: https://review.openstack.org/#/c/522685/
    
    Change-Id: Id577ae9d08dc0fae3dcac78d98ec0456f8378417
    Closes-bug: #1768454
    
  - Merge "Remove deprecated DEFAULT options"
  - Update auth_url value in install docs
    
    Follow the keystone install guide by using port 5000
    as the default auth_url, this change is to update manila
    install guide to follow that.
    
    Change-Id: I1dadd202742a88d80978065f0501b668e859793c
    Closes-bug: #1754104
    
  - Merge "Fix doc build warnings"
  - Merge "[Manila Unity] Set unity_server_meta_pool option as required"
  - Fix doc build warnings
    
    Building locally produces warnings that upstream
    gate lets pass.  Fix these because upstream is
    changing [1].
    
    [1] https://review.openstack.org/#/c/564232
    
    Change-Id: Ibc3e0e5e18d0a587c75b2b5cb4d6760d481a7807
    
  - Merge "Remove ordering attempts of 'unorderable types'"
  - Add ou to security service
    
    Allows to configure in which organizational unit the share ends up
    
    APIImpact
    
    Change-Id: I70fd4e0ea7898e85dff59a927b3cb086d5e408ac
    Needed-By: I77d87c8e6f98054f2f02bc4202c14314ff321964
    Partial-Bug: #1696669
    
  - [Manila Unity] Set unity_server_meta_pool option as required
    
    Change-Id: Ie87b10d4199ac775adba20f645f56650bbdea301
    Closes-bug: #1765580
    
  - Use 'Default' as the value of domain name in install guide
    
    The Manila install guide use default in some place as the value of
    user_domain_name and project_domain_name, whereas the Keystone
    install guide, which people would be consulting earlier, instructs
    the installer to use 'Default'.  Since the name is case-sensitive,
    this is causing problems for first-time installers of OpenStack.
    
    Ref: https://bugs.launchpad.net/keystone/+bug/1229093
    
    Change-Id: I1cf4345abd3ae8923f8d1fbd0706737494745d84
    Closes-bug: #1766475
    
  - Remove deprecated DEFAULT options
    
    Cinder, nova, neutron has deprecated some default options
    since last release, so it is time to remove those options
    in this version. refer to the following deprecation patch.
    
    Ref: https://review.openstack.org/#/c/290511/
    
    Closes-bug: #1766384
    
    Change-Id: I595ff2c82ef40566145fedb202e549be69c45e0c
    
  - uncap eventlet
    
    We will manage the eventlet version using constraints now. See the
    thread starting at
    http://lists.openstack.org/pipermail/openstack-dev/2018-April/129096.html
    for more details.
    
    Also adjust lower_contstraints.txt to match requirements.txt and
    test_requirements.txt so that the requirements job will pass.
    
    Change-Id: Ib1d74405c239f0a7d62f327a3aad6a9c8fd549e7
    Signed-off-by: Doug Hellmann <[email protected]>
    
  - Merge "Support filter search for share type API"
  - Update auth_uri option to www_authenticate_uri
    
    Option auth_uri from group keystone_authtoken is deprecated[1].
    Use option www_authenticate_uri from group keystone_authtoken.
    
    [1]https://review.openstack.org/#/c/508522/
    
    Change-Id: Ic9c19c216fa85ac5125b39a6346539b0e8eacbfd
    
  - Fix allow the use of blank in user group name to access the share
    
    Allows the use of blank in user group name, manila client also need to fix
    
    Change-Id: I636e485992185ed8a766eddb6cba89daff0bd00e
    Partial-Bug: #1733494
    
  - move securiy service error explanation from comment
    
    Change-Id: If81d6cfd41e8aec63aaa95f3190eec44d7d2fc01
    
  - Merge "Run pep8/fast8 with python3"
  - Run pep8/fast8 with python3
    
    Change-Id: I056d7228834f5becf36ccbd4f7473e532cc5a431
    
  - Merge "Circumvent bug #1747721 to prevent CI failures"
  - Circumvent bug #1747721 to prevent CI failures
    
    Change-Id: I0fb057657fdf568b591bc6a43cfd6eb355010523
    Related-Bug: #1747721
    Signed-off-by: Rishabh Dave <[email protected]>
    
  - Remove option standalone_network_plugin_ip_version
    
    'standalone_network_plugin_ip_version' option has been
    deprecated. This option has been replaced by
    'network_plugin_ipv4_enabled' and
    'network_plugin_ipv6_enabled' options.
    
    Change-Id: I0251fecddac74578698bcda5d46e44ca16bd8a76
    
  - Merge "Updated from global requirements"
  - Merge "Fix typos in help text of Generic driver and ZFSSA config opts"
  - Updated from global requirements
    
    Change-Id: I3e146eaf31829bb870fc730f4d56b618a60e4c8c
    
  - Merge "Update documentation links"
  - Merge "Disable tempest in rally jobs"
  - Merge "Modify grammatical errors"
  - Merge "Remove the deprecated "giturl" option"
  - Support filter search for share type API
    
    Add support for extra_specs filter search in type list API.
    
    Change-Id: I43fbef2a32489f2064586a3674eb34329f3503c4
    Implements: blueprint support-filter-search-for-share-type
    
  - Merge "Don't attempt to escalate manila-manage privileges"
  - Merge "use http code constant instead of int"
  - Merge "add lower-constraints job"
  - Merge "Move openstackdocstheme to extensions in api-ref"
  - Fix typos in help text of Generic driver and ZFSSA config opts
    
    Change 'the serviceinstance' to 'the service instance' in opts
     "Path to the x509 certificate used for accessing the service
     instance."
    
    Change 'theservice instance' to 'the service instance' in opts
     "Use x509 certificates in order to authenticate to the service
     instance."
    
    Change 'userpassword' to 'user's password' in opts
     "ZFSSA management authorized user's password."
    
    Change-Id: I3b8f4d7e06aac1a72632e665f20fabccc23379a4
    Closes-bug: #1650872
    Closes-Bug: #1650875
    
  - Remove the deprecated "giturl" option
    
    From openstackdocstheme 1.18.0, valid Git URLs can be retrieved by
    openstackdocstheme[1], we do not need giturl option anymore.
    
    [1] https://review.openstack.org/532163
    
    Change-Id: I11d4af5807a2f95dd6e6d06ae5c5f9a9ea45e2f9
    
  - Disable tempest in rally jobs
    
    Change-Id: I23aff041fde91b445ccde73e3fd8fc90359c892e
    
  - Modify grammatical errors
    
    Change-Id: I060450d4c9323fc843baba03c6acd0aea49f67b6
    
  - Merge "Replace chinese double quotes to English double quotes"
  - Merge "Adding driver to mysql connection URL"
  - Merge "Replace Chinese quotes to English quotes"
  - Merge "Use rest_status_code for api-ref response codes"
  - Use rest_status_code for api-ref response codes
    
    Rather than our freeform way of listing response codes in our
    api-ref, we should be using the os-api-ref extension option to
    get nicely formatted response code listings.
    
    https://docs.openstack.org/os-api-ref/latest/usage.html#rest-status-code
    
    Change-Id: Ibafafa2f9c3b301b5cdd9b1cb3b8b6d678faa731
    
  - Merge "Update the new PTI for document build"
  - Merge "Updated from global requirements"
  - Merge "Fix typos"
  - Updated from global requirements
    
    Change-Id: I64f3bc5686b5ab4f81b6462da60febd66fbf3499
    
  - add lower-constraints job
    
    Create a tox environment for running the unit tests against the lower
    bounds of the dependencies.
    
    Create a lower-constraints.txt to be used to enforce the lower bounds
    in those tests.
    
    Add openstack-tox-lower-constraints job to the zuul configuration.
    
    See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
    for more details.
    
    Change-Id: I5f9a218429c1efc1fddae1945aef7110c4e031ee
    Depends-On: https://review.openstack.org/555034
    Signed-off-by: Doug Hellmann <[email protected]>
    
  - Update the new PTI for document build
    
    This review already follows the new PTI
    https://review.openstack.org/#/c/530866/
    
    However, we also should remove [build_sphinx] section
    as described in:
    http://lists.openstack.org/pipermail/openstack-dev/2018-March/128594.html
    
    Change-Id: I86651f3311f514c5520ff878a6f6ba8f9de5c751
    
  - Merge "Add manila-tempest-plugin as a requirement in rally job definitions"
  - Merge "Update docs since manila_tempest_tests are installed system-wide"
  - Merge "Fetch and install manila-tempest-plugin system-wide"
  - Add manila-tempest-plugin as a requirement in rally job definitions
    
    Depends-On: I0844cdb48b9d415bd341c4687620412178be871b
    Change-Id: I1336c8a4d11762cc355ce5a48899d62646563e28
    Signed-off-by: Rishabh Dave <[email protected]>
    
  - Merge "Add manila.data.helper options to config sample"
  - use http code constant instead of int
    
    Change-Id: I71f3271bd0cfaac61f8e86e8fa373257ce22681e
    
  - Adding driver to mysql connection URL
    
    With current URL [1], default driver will be used.
    In order to ensure the compatibility, it is better to include the exact driver [2].
    
    [1] connection = mysql://
    [2] connection = mysql+pymysql://
    
    Change-Id: Ibd6418a9053103fa743207d672f6f0a3b23c30f5
    
  - Merge "Update doc name and path for dell emc vnx and unity driver"
  - Merge "Fix tap device disappear after node restart"
  - Log config options with oslo.config
    
    This removes some custom code inherited from Cinder which was handling
    the output of secret options in a bad way. This patch utilizes Oslo's
    existing utilities to output the Manila configuration options securely.
    
    Filtering will be done with the "secret=True" option flag.
    
    Major thanks to Eric Harney for introducing this fix to Cinder.
    
    Change-Id: I894e011680661c0b73b9592f70a6457e403f18c6
    Related-Bug: #1750074
    
  - Fix tap device disappear after node restart
    
    When use driver_handles_share_servers driver, the tap device will
    down and the tap device  mac address is changed after restart the
    node, that will caused manila can not manage share that created
    by this service.
    This path fix this issue. When restart manila-share service,
    call setup_connectivity_with_service_instances() to create host port
    and check the the mac address.
    
    Change-Id: Ibcdd4f58f15a53c69d35db06bc42283859349758
    Closes-Bug:#1688155
    
  - Updated from global requirements
    
    Change-Id: I411f954e1017cda61a32b58dad20caff74f0f031
    
  - Update doc name and path for dell emc vnx and unity driver
    
    Change-Id: If85f12f90e2494fe0d9…
Carthaca pushed a commit to sapcc/manila that referenced this pull request Feb 4, 2019
@gouthampacha @Carthaca
[Docs] Don't include unittest documentation
8257e24 
The `test_quota` and `test_policy` modules
don't need to be documented, since they present
no meaningful information to contributors.

Removing these also avoids the docstring
formatting issues that ddt may introduce
to the sphinx build. [1]

[1] datadriventests/ddt#51

Change-Id: I8136e8a000e04bcc213a746c7d793bf9373b1b38
Closes-Bug: #1783124
Carthaca pushed a commit to sapcc/manila that referenced this pull request Feb 4, 2019
@gouthampacha @Carthaca
[Docs] Don't include unittest documentation
2113892 
The `test_quota` and `test_policy` modules
don't need to be documented, since they present
no meaningful information to contributors.

Removing these also avoids the docstring
formatting issues that ddt may introduce
to the sphinx build. [1]

[1] datadriventests/ddt#51

Change-Id: I8136e8a000e04bcc213a746c7d793bf9373b1b38
Closes-Bug: #1783124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wswld wswld wswld left review comments

@txels txels txels left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palakpsheth @codecov-io @wswld @txels