Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let flake8 pull a version of pep8 it requires #28

Merged
merged 2 commits into from
May 14, 2015

Conversation

mycharis
Copy link

flake8-2.4.0 does not support pep8>=1.6.0 which resulted in dependency conflict with the latest stable 1.6.2 pulled in explicitly

flake8-2.4.0 does not support pep8>=1.6.0 which resulted in dependency conflict with the latest stable 1.6.2
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling d363f47 on mycharis:mycharis-fix-tox-ini into 6175369 on txels:master.

@txels
Copy link
Collaborator

txels commented May 14, 2015

Good point. Unfortunately the travis build doesn't rely on tox (because in this way I can get a better itemised build output in Travis by Python version) but that causes some duplication of requirements.

The same you did here, in requirements/test.txt would fix the Travis build.

flake8-2.4.0 does not support pep8>=1.6.0 which resulted in dependency conflict with the latest stable 1.6.2
@mycharis
Copy link
Author

Added, all green now. :)

@txels
Copy link
Collaborator

txels commented May 14, 2015

Wonders, thanks!

txels added a commit that referenced this pull request May 14, 2015
Let flake8 pull a version of pep8 it requires
@txels txels merged commit ef48408 into datadriventests:master May 14, 2015
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 7750da3 on mycharis:mycharis-fix-tox-ini into 6175369 on txels:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants