Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sanity test issue to account for homepage redesign #4794

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

dwnoble
Copy link
Contributor

@dwnoble dwnoble commented Dec 12, 2024

The sanity tests started failing after migrating the homepage to use emotion

  • Added validation to run_website_sanity.sh to error gracefully if no $domain arg is passed in
  • Allow setting the protocol along with $domain arg to allow testing from localhost
  • Added data-testid attribute to LinkChip, LinkBox, and QueryLink element to allow test cases to select dom elements without a fixed class name
  • Updated sanity.py test to use data-testid attribute to select elements

@dwnoble dwnoble requested review from keyurva and gmechali December 12, 2024 21:48
Copy link
Contributor

@gmechali gmechali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

@dwnoble dwnoble enabled auto-merge (squash) December 12, 2024 21:57
Copy link
Contributor

@keyurva keyurva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, Dan!

@dwnoble dwnoble merged commit 97873c0 into datacommonsorg:master Dec 13, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants