Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a list of words to skip Autocomplete trigger and abort old requests #4751

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

gmechali
Copy link
Contributor

The list of words can grow later, for now we're just taking the keywords from the queries in the homepage.
Skipping the old requests became a requirement because requests for TELL would return faster than the previous one for TEL, so we still saw results from "TEL".

This PR fixes both of these things.

…when a new request has been triggered.
@gmechali gmechali marked this pull request as ready for review November 21, 2024 02:58
@gmechali gmechali requested a review from dwnoble November 21, 2024 02:58
Copy link
Contributor

@beets beets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these fixes!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@gmechali gmechali merged commit 85f4e06 into datacommonsorg:master Nov 22, 2024
9 checks passed
@gmechali gmechali deleted the notrigger branch December 5, 2024 17:20
gmechali added a commit to gmechali/website that referenced this pull request Dec 5, 2024
…sts (datacommonsorg#4751)

The list of words can grow later, for now we're just taking the keywords
from the queries in the homepage.
Skipping the old requests became a requirement because requests for TELL
would return faster than the previous one for TEL, so we still saw
results from "TEL".

This PR fixes both of these things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants