Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger autocomplete for 2 letter query if that is "US" #4730

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

gmechali
Copy link
Contributor

@gmechali gmechali commented Nov 12, 2024

Autocomplete queries only trigger on 3+ letter words. With this change, we add one exception, to trigger on a two letter word if that is "US"

US Triggers: https://screenshot.googleplex.com/AzqxmiqBBr2ocVn
Other 2 letter words do not: https://screenshot.googleplex.com/7tXxN8p34MT4SUU
Life expectancy in us: https://screenshot.googleplex.com/6k7WK2oiJqWedxK

@gmechali gmechali marked this pull request as ready for review November 12, 2024 20:27
@gmechali gmechali requested a review from keyurva November 12, 2024 20:27
Copy link
Contributor

@keyurva keyurva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gabe!

@gmechali gmechali merged commit 8b7bdf7 into datacommonsorg:master Nov 12, 2024
9 checks passed
@gmechali gmechali deleted the usafix branch November 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants