Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stable branch commit check clearer #4727

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

hqpho
Copy link
Contributor

@hqpho hqpho commented Nov 8, 2024

Summary

  • Include remediation instructions in error message.
  • Rename check file to "Release branch checks" (release-branch-checks.yml)
    • This makes the prefix of the check where it's listed on a PR non-redundant, and also sets us up to potentially have more checks in there in the future.
    • I've called it "Release branch checks" instead of "Custom DC stable branch checks" because technically the same checks would apply if we ever wanted to use release branches for website prod and staging.
  • Rename job to "verify_all_commits_are_already_in_master" so the name makes sense on its own.

Also, update version of checkout action to one that isn't about to be deprecated.

Screenshots

On PR

on PR

After clicking through from PR

after clicking through from PR

In Actions tab

in actions tab

After clicking through from Actions tab

after clicking through from actions tab

@hqpho hqpho requested a review from beets November 8, 2024 21:18
@hqpho hqpho requested a review from keyurva November 11, 2024 20:31
@hqpho hqpho merged commit 0bce14d into datacommonsorg:master Nov 12, 2024
9 checks passed
@hqpho hqpho deleted the cdcUpdateTest branch November 12, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants